From: Namhyung Kim <namhyung@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
fweisbec@gmail.com, paulus@samba.org, tglx@linutronix.de
Subject: Re: [PATCH] perf tools: Allow multiple threads or processes in record, stat, top
Date: Fri, 10 Feb 2012 14:42:01 +0900 [thread overview]
Message-ID: <4F34AE29.5010202@gmail.com> (raw)
In-Reply-To: <20120209144451.GB2526@infradead.org>
Hello,
2012-02-09 11:44 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 09, 2012 at 12:34:49PM -0200, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Feb 09, 2012 at 08:37:27AM +0100, Ingo Molnar escreveu:
>>>
>>> * David Ahern<dsahern@gmail.com> wrote:
>>>
>>>>> I was trying to remove ctype.h, you might use util.h here.
>>>>
>>>> Right, knew that. But, in this case I am adding a call to
>>>> isdigit which means a direct dependency on ctype.h. I would
>>>> prefer a direct relationship versus an indirect via util.h
>>>
>>> Please just remove ctype.h *altogether* from perf, it's just an
>>> insane header.
>>>
>>> Have a look at how Git solves these types of problems, it
>>> defines sane string functions in git-compat-util.h:
>>
>> Yeah, these are in util.h, that doesn't includes ctype.h
>>
>> I'm fixing this up and also that s/UUID/UID/g Kim pointed out,
>> then testing if the python binding still is ok with these changes.
>
> [root@aninha linux]# tools/perf/python/twatch.py
> Traceback (most recent call last):
> File "tools/perf/python/twatch.py", line 16, in<module>
> import perf
> ImportError: /home/acme/git/build/perf/python/perf.so: undefined symbol:
> ui__error
> [root@aninha linux]#
>
> it breaks, I'll check an alternative way to report problems without
> calling ui__ methods from thread_map.
>
> - Arnaldo
I have a different result:
$ git checkout tip/perf/core
...
HEAD is now at c98fdeaa9273... x86/sched/perf/AMD: Set sched_clock_stable
$
$ patch -p1 < perf-allow-multiple-threads.patch
patching file tools/perf/Documentation/perf-record.txt
patching file tools/perf/Documentation/perf-stat.txt
patching file tools/perf/Documentation/perf-top.txt
patching file tools/perf/builtin-record.c
patching file tools/perf/builtin-stat.c
patching file tools/perf/builtin-test.c
patching file tools/perf/builtin-top.c
patching file tools/perf/perf.h
patching file tools/perf/util/evlist.c
patching file tools/perf/util/evlist.h
patching file tools/perf/util/evsel.c
patching file tools/perf/util/thread_map.c
patching file tools/perf/util/thread_map.h
patching file tools/perf/util/top.c
patching file tools/perf/util/top.h
patching file tools/perf/util/usage.c
patching file tools/perf/util/util.h
patch unexpectedly ends in middle of line
$
$ cd tools/perf
$ make -j8
Makefile:417: No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support.
Please install new elfutils-devel/libdw-dev
Makefile:604: No bfd.h/libbfd found, install binutils-dev[el]/zlib-static to gain symbol demangling
GEN common-cmds.h
...
AR libperf.a
LINK perf
$
$ sudo python/twatch.py
Traceback (most recent call last):
File "python/twatch.py", line 41, in <module>
main()
File "python/twatch.py", line 25, in main
evsel.open(cpus = cpus, threads = threads);
OSError: [Errno 22] Invalid argument
Thanks,
Namhyung
next prev parent reply other threads:[~2012-02-10 5:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:32 [PATCH] perf tools: Allow multiple threads or processes in record, stat, top David Ahern
2012-02-09 1:19 ` Namhyung Kim
2012-02-09 2:52 ` David Ahern
2012-02-09 5:36 ` Namhyung Kim
2012-02-09 6:04 ` David Ahern
2012-02-09 7:37 ` Ingo Molnar
2012-02-09 14:34 ` Arnaldo Carvalho de Melo
2012-02-09 14:44 ` Arnaldo Carvalho de Melo
2012-02-10 5:42 ` Namhyung Kim [this message]
2012-02-10 14:28 ` Arnaldo Carvalho de Melo
2012-02-12 10:45 ` [PATCH] perf tools: Fix build dependency of perf python extension Namhyung Kim
2012-02-17 9:44 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-02-10 19:24 ` [PATCH] perf tools: Allow multiple threads or processes in record, stat, top Arnaldo Carvalho de Melo
2012-02-10 19:32 ` David Ahern
2012-02-10 19:34 ` Arnaldo Carvalho de Melo
2012-02-10 19:46 ` David Ahern
2012-02-10 19:58 ` Arnaldo Carvalho de Melo
2012-02-17 9:46 ` [tip:perf/core] " tip-bot for David Ahern
2012-03-02 10:56 ` Ingo Molnar
2012-03-02 14:21 ` David Ahern
2012-03-02 14:52 ` David Ahern
2012-03-03 7:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F34AE29.5010202@gmail.com \
--to=namhyung@gmail.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).