From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Dan.Morav@nuvoton.com,
KC@nuvoton.com, Dan Morav <dmorav@nuvoton.com>
Subject: Re: [PATCH 1/2] TPM: Nuvoton I2C driver
Date: Fri, 10 Feb 2012 13:32:12 -0500 [thread overview]
Message-ID: <4F3562AC.5090701@linux.vnet.ibm.com> (raw)
In-Reply-To: <1328620014-9369-2-git-send-email-srajiv@linux.vnet.ibm.com>
On 02/07/2012 08:06 AM, Rajiv Andrade wrote:
> From: Dan.Morav@nuvoton.com<Dan.Morav@nuvoton.com>
>
> Below are the additions for WPCT301/NPCT501 Nuvoton Technology
> TPM with I2C interface device driver. This driver uses Linux I2C
> bus driver to interface with the I2C bus and Linux TPM driver (tpm.ko),
> to export the standard Linux TPM interface. This driver requires an
> I2C bus driver and TPM driver (tpm.ko) to be loaded prior to its loading.
> This driver tested on Linux kernel version 3.3 on an x86 based platform.
>
> Signed-off-by: Dan Morav<dmorav@nuvoton.com>
> Signed-off-by: Rajiv Andrade<srajiv@linux.vnet.ibm.com>
[...]
> +
> endif # TCG_TPM
> diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
> index ea3a1e0..064669a 100644
> --- a/drivers/char/tpm/Makefile
> +++ b/drivers/char/tpm/Makefile
> @@ -9,3 +9,4 @@ obj-$(CONFIG_TCG_TIS) += tpm_tis.o
> obj-$(CONFIG_TCG_NSC) += tpm_nsc.o
> obj-$(CONFIG_TCG_ATMEL) += tpm_atmel.o
> obj-$(CONFIG_TCG_INFINEON) += tpm_infineon.o
> +obj-$(CONFIG_TCG_NUVOTON_I2C) += tpm_nuvoton_i2c.o
> diff --git a/drivers/char/tpm/tpm_nuvoton_i2c.c b/drivers/char/tpm/tpm_nuvoton_i2c.c
> new file mode 100644
> index 0000000..daf0d49
> --- /dev/null
> +++ b/drivers/char/tpm/tpm_nuvoton_i2c.c
> @@ -0,0 +1,718 @@
> +/******************************************************************************
> + * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501,
> + * based on the TCG TPM Interface Spec version 1.2.
> + * Specifications at www.trustedcomputinggroup.org
Since it's implemented following non-proprietary specs, would this
driver qualify as the generic tpm_i2c driver or is there anything
besides the device-id,vendor-id + firmware work-around in the driver
specific to this particular device implementation.
Regards,
Stefan
next prev parent reply other threads:[~2012-02-10 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 13:06 [PATCH 1/2] TPM: Nuvoton I2C driver Rajiv Andrade
2012-02-10 18:32 ` Stefan Berger [this message]
2012-02-13 16:43 ` Rajiv Andrade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3562AC.5090701@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=Dan.Morav@nuvoton.com \
--cc=KC@nuvoton.com \
--cc=dmorav@nuvoton.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srajiv@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).