From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Greg KH <greg@kroah.com>, Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH] staging: fix powerpc linux-next break on zsmalloc
Date: Tue, 14 Feb 2012 08:35:13 -0600 [thread overview]
Message-ID: <4F3A7121.9010803@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F3A480C.9090407@gmx.de>
On 02/14/2012 05:39 AM, Marc Dietrich wrote:
> Am 14.02.2012 12:22, schrieb Marc Dietrich:
>> Am 13.02.2012 15:47, schrieb Seth Jennings:
>>> linux/vmalloc.h added to zsmalloc-main.c to resolve implicit
>>> declaration errors.
>>>
>>> X86 dependency added to zsmalloc and dependent drivers zcache and zram.
>>>
>>> This X86 only requirement is not ideal. Working to find portable
>>> functions for __flush_tlb_one and set_pte.
>>
>> sorry, zcache/zram works fine one ARM here. Why not depend on !POWERPC?
>
> ups, sorry again, I tested an older version only. flush_tlb_one and
> set_pte is only used with the new allocator as it seems.
It would seem that the cpu-local tlb page flushing function for ARM
is local_flush_tlb_kernel_page(), by look at the kmap_atomic() code
in arch/arm/mm/highmem.c.
So each arch is using a slightly different approach here.
A simple #define per-arch could make a it a common call. I think
I'm going to code it up and see how it goes.
--
Seth
next prev parent reply other threads:[~2012-02-14 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 14:47 [PATCH] staging: fix powerpc linux-next break on zsmalloc Seth Jennings
2012-02-14 11:22 ` Marc Dietrich
2012-02-14 11:39 ` Marc Dietrich
2012-02-14 14:25 ` Seth Jennings
2012-02-14 14:35 ` Seth Jennings [this message]
2012-02-14 16:21 ` Marc Dietrich
2012-03-12 14:34 ` Seth Jennings
2012-03-12 20:26 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3A7121.9010803@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=ngupta@vflare.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).