From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
tglx@linutronix.de, devicetree-discuss@lists.ozlabs.org,
avictor.za@gmail.com, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 3/9] ARM/USB: at91/ohci-at91: remove the use of irq_to_gpio
Date: Fri, 17 Feb 2012 10:41:32 +0100 [thread overview]
Message-ID: <4F3E20CC.5090205@atmel.com> (raw)
In-Reply-To: <fab15f7eaf6622e68e62bc3afa533b12f48ca27e.1329139662.git.nicolas.ferre@atmel.com>
On 02/13/2012 03:43 PM, Nicolas Ferre :
> irq_to_gpio() macro will be removed from AT91 GPIO interrupt
> controller. So we replace it with the use of gpio_to_irq()
> and a reworked test.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: linux-usb@vger.kernel.org
Hi Greg,
I would like to queue this patch through arm-soc git tree (with all AT91
material of this patch series).
So, can I have your "Acked-by" on this one?
> ---
> drivers/usb/host/ohci-at91.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
> index 77afabc..8e855eb 100644
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c
> @@ -448,10 +448,11 @@ static irqreturn_t ohci_hcd_at91_overcurrent_irq(int irq, void *data)
>
> /* From the GPIO notifying the over-current situation, find
> * out the corresponding port */
> - gpio = irq_to_gpio(irq);
> for (port = 0; port < ARRAY_SIZE(pdata->overcurrent_pin); port++) {
> - if (pdata->overcurrent_pin[port] == gpio)
> + if (gpio_to_irq(pdata->overcurrent_pin[port]) == irq) {
> + gpio = pdata->overcurrent_pin[port];
> break;
> + }
> }
>
> if (port == ARRAY_SIZE(pdata->overcurrent_pin)) {
Thanks, best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-02-17 9:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 14:43 [PATCH 0/9] ARM: at91: irqdomain and device tree for AIC and GPIO Nicolas Ferre
2012-02-13 14:43 ` [PATCH v5 1/9] ARM: at91/aic: add irq domain and device tree support Nicolas Ferre
2012-02-13 14:43 ` [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out of structure initialization Nicolas Ferre
2012-02-13 20:02 ` Ryan Mallon
2012-02-14 9:04 ` Nicolas Ferre
2012-02-14 9:48 ` Russell King - ARM Linux
2012-02-13 14:43 ` [PATCH 3/9] ARM/USB: at91/ohci-at91: remove the use of irq_to_gpio Nicolas Ferre
2012-02-17 9:41 ` Nicolas Ferre [this message]
2012-02-17 16:59 ` Greg Kroah-Hartman
2012-02-13 14:43 ` [PATCH 4/9] ARM: at91/gpio: change comments and one variable name Nicolas Ferre
2012-02-13 14:43 ` [PATCH v5 5/9] ARM: at91/gpio: add irqdomain and DT support Nicolas Ferre
2012-02-13 14:43 ` [PATCH 6/9] ARM: at91/gpio: non-DT builds do not have gpio_chip.of_node field Nicolas Ferre
2012-02-13 14:43 ` [PATCH 7/9] ARM: at91/gpio: add .to_irq gpio_chip handler Nicolas Ferre
2012-02-13 14:43 ` [PATCH 8/9] ARM: at91/gpio: remove the static specification of gpio_chip.base Nicolas Ferre
2012-02-13 14:43 ` [PATCH 9/9] ARM: at91/board-dt: remove AIC irq domain from board file Nicolas Ferre
2012-02-13 22:10 ` [PATCH v5 1/9] ARM: at91/aic: add irq domain and device tree support Rob Herring
2012-02-14 10:24 ` Nicolas Ferre
2012-02-14 14:11 ` Rob Herring
2012-02-17 9:26 ` Nicolas Ferre
2012-02-17 9:27 ` [PATCH] ARM: at91: AIC and GPIO IRQ device tree initilization Nicolas Ferre
2012-02-21 10:06 ` Nicolas Ferre
2012-02-21 10:16 ` Russell King - ARM Linux
2012-02-21 14:07 ` Rob Herring
2012-02-22 9:07 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3E20CC.5090205@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=avictor.za@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).