linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: balbi@ti.com, dahlmann.thomas@arcor.de,
	gregkh@linuxfoundation.org, linux-geode@lists.infradead.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] amd5536udc: fix type of ep_string.
Date: Sat, 25 Feb 2012 19:25:22 +0400	[thread overview]
Message-ID: <4F48FD62.7090304@mvista.com> (raw)
In-Reply-To: <1330132502-17057-6-git-send-email-tipecaml@gmail.com>

Hello.

On 25-02-2012 5:15, Cyril Roelandt wrote:

> Use "static const char *" instead of "static const char *const".

    You're doing exactly oppposite.

> Signed-off-by: Cyril Roelandt<tipecaml@gmail.com>
> ---
>   drivers/usb/gadget/amd5536udc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

> diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
> index 3d563d0..16079bd 100644
> --- a/drivers/usb/gadget/amd5536udc.c
> +++ b/drivers/usb/gadget/amd5536udc.c
> @@ -140,7 +140,7 @@ static DECLARE_TASKLET(disconnect_tasklet, udc_tasklet_disconnect,
>
>   /* endpoint names used for print */
>   static const char ep0_string[] = "ep0in";
> -static const char *ep_string[] = {
> +static const char *const ep_string[] = {
>   	ep0_string,
>   	"ep1in-int", "ep2in-bulk", "ep3in-bulk", "ep4in-bulk", "ep5in-bulk",
>   	"ep6in-bulk", "ep7in-bulk", "ep8in-bulk", "ep9in-bulk", "ep10in-bulk",

WBR, Sergei

  reply	other threads:[~2012-02-25 15:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25  1:14 [PATCH 0/6] drivers/usb/gadget/amd5536udc.c: code cleanup Cyril Roelandt
2012-02-25  1:14 ` [PATCH 1/6] amd5536udc: Fix brace coding style issues Cyril Roelandt
2012-02-27 14:35   ` Felipe Balbi
2012-02-25  1:14 ` [PATCH 2/6] amd5536udc: Fix " Cyril Roelandt
2012-02-27 14:35   ` Felipe Balbi
2012-02-25  1:14 ` [PATCH 3/6] amd5536udc: Fix indentation Cyril Roelandt
2012-02-27 14:36   ` Felipe Balbi
2012-02-25  1:15 ` [PATCH 4/6] amd5536udc: use the DEFINE_PCI_DEVICE_TABLE macro Cyril Roelandt
2012-02-27 14:37   ` Felipe Balbi
2012-02-25  1:15 ` [PATCH 5/6] amd5536udc: fix type of ep_string Cyril Roelandt
2012-02-25 15:25   ` Sergei Shtylyov [this message]
2012-02-26 14:57     ` Cyril Roelandt
2012-02-26 15:00     ` [PATCH 5/6] amd5536udc: Fix the " Cyril Roelandt
2012-02-27 10:51       ` Sergei Shtylyov
2012-02-27 14:37       ` Felipe Balbi
2012-02-25  1:15 ` [PATCH 6/6] amd5536udc: Remove old CVS markers Cyril Roelandt
2012-02-27 14:37   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F48FD62.7090304@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=balbi@ti.com \
    --cc=dahlmann.thomas@arcor.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).