* [PATCH] x32: make sure TS_COMPAT is cleared for x32 tasks
@ 2012-02-26 4:25 Bobby Powers
2012-02-26 5:50 ` [tip:x86/x32] x32: Make " tip-bot for Bobby Powers
2012-02-26 5:54 ` [PATCH] x32: make " H. Peter Anvin
0 siblings, 2 replies; 3+ messages in thread
From: Bobby Powers @ 2012-02-26 4:25 UTC (permalink / raw)
To: linux-kernel; +Cc: hpa, mingo, tglx, x86, hjl.tools, Bobby Powers
If a process has a non-x32 ia32 personality and changes to x32, the
process would keep its TS_COMPAT flag. x32 uses the presence of the
x32 flag on a syscall to determine compat status, so make sure
TS_COMPAT is cleared.
Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
---
arch/x86/kernel/process_64.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index e9ec8f1..a465973 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -539,6 +539,9 @@ void set_personality_ia32(bool x32)
clear_thread_flag(TIF_IA32);
set_thread_flag(TIF_X32);
current->personality &= ~READ_IMPLIES_EXEC;
+ /* is_compat_task() uses the presence of the x32
+ syscall bit flag to determine compat status */
+ current_thread_info()->status &= ~TS_COMPAT;
} else {
set_thread_flag(TIF_IA32);
clear_thread_flag(TIF_X32);
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [tip:x86/x32] x32: Make sure TS_COMPAT is cleared for x32 tasks
2012-02-26 4:25 [PATCH] x32: make sure TS_COMPAT is cleared for x32 tasks Bobby Powers
@ 2012-02-26 5:50 ` tip-bot for Bobby Powers
2012-02-26 5:54 ` [PATCH] x32: make " H. Peter Anvin
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Bobby Powers @ 2012-02-26 5:50 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, bobbypowers, hpa, mingo, tglx
Commit-ID: ce5f7a99df87918b5be4618a9386213a8e9a7146
Gitweb: http://git.kernel.org/tip/ce5f7a99df87918b5be4618a9386213a8e9a7146
Author: Bobby Powers <bobbypowers@gmail.com>
AuthorDate: Sat, 25 Feb 2012 23:25:38 -0500
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Sat, 25 Feb 2012 20:42:18 -0800
x32: Make sure TS_COMPAT is cleared for x32 tasks
If a process has a non-x32 ia32 personality and changes to x32, the
process would keep its TS_COMPAT flag. x32 uses the presence of the
x32 flag on a syscall to determine compat status, so make sure
TS_COMPAT is cleared.
Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
Link: http://lkml.kernel.org/r/1330230338-25077-1-git-send-email-bobbypowers@gmail.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/kernel/process_64.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index a0701da..32e0412 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -540,6 +540,9 @@ void set_personality_ia32(bool x32)
clear_thread_flag(TIF_IA32);
set_thread_flag(TIF_X32);
current->personality &= ~READ_IMPLIES_EXEC;
+ /* is_compat_task() uses the presence of the x32
+ syscall bit flag to determine compat status */
+ current_thread_info()->status &= ~TS_COMPAT;
} else {
set_thread_flag(TIF_IA32);
clear_thread_flag(TIF_X32);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x32: make sure TS_COMPAT is cleared for x32 tasks
2012-02-26 4:25 [PATCH] x32: make sure TS_COMPAT is cleared for x32 tasks Bobby Powers
2012-02-26 5:50 ` [tip:x86/x32] x32: Make " tip-bot for Bobby Powers
@ 2012-02-26 5:54 ` H. Peter Anvin
1 sibling, 0 replies; 3+ messages in thread
From: H. Peter Anvin @ 2012-02-26 5:54 UTC (permalink / raw)
To: Bobby Powers; +Cc: linux-kernel, mingo, tglx, x86, hjl.tools, Andi Kleen
On 02/25/2012 08:25 PM, Bobby Powers wrote:
> If a process has a non-x32 ia32 personality and changes to x32, the
> process would keep its TS_COMPAT flag. x32 uses the presence of the
> x32 flag on a syscall to determine compat status, so make sure
> TS_COMPAT is cleared.
>
> Signed-off-by: Bobby Powers <bobbypowers@gmail.com>
> ---
> arch/x86/kernel/process_64.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
> index e9ec8f1..a465973 100644
> --- a/arch/x86/kernel/process_64.c
> +++ b/arch/x86/kernel/process_64.c
> @@ -539,6 +539,9 @@ void set_personality_ia32(bool x32)
> clear_thread_flag(TIF_IA32);
> set_thread_flag(TIF_X32);
> current->personality &= ~READ_IMPLIES_EXEC;
> + /* is_compat_task() uses the presence of the x32
> + syscall bit flag to determine compat status */
> + current_thread_info()->status &= ~TS_COMPAT;
> } else {
> set_thread_flag(TIF_IA32);
> clear_thread_flag(TIF_X32);
I suspect we should also clear TS_COMPAT in set_personality_64() ...
this is not x32-related, but would affect the behavior when execing a
64-bit task from an i386 compatibility task. I have no idea if it
actually makes any difference, and clearly it can't have been too broken
since noone has found a problem all these years, but it looks wrong...
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-26 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-26 4:25 [PATCH] x32: make sure TS_COMPAT is cleared for x32 tasks Bobby Powers
2012-02-26 5:50 ` [tip:x86/x32] x32: Make " tip-bot for Bobby Powers
2012-02-26 5:54 ` [PATCH] x32: make " H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).