From: "H. Peter Anvin" <hpa@zytor.com>
To: Jim Kukunas <james.t.kukunas@linux.intel.com>
Cc: neilb@suse.de, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: lib/raid6: SSSE3 optimized recovery functions v2
Date: Thu, 12 Apr 2012 13:14:05 -0700 [thread overview]
Message-ID: <4F87378D.7080505@zytor.com> (raw)
In-Reply-To: <1334261073-14781-1-git-send-email-james.t.kukunas@linux.intel.com>
On 04/12/2012 01:04 PM, Jim Kukunas wrote:
>
> This keeps with the existing code conventions. The code block is:
>
> extern const u8 raid6_gfmul[256][256] __attribute__((aligned(256)));
> extern const u8 raid6_vgfmul[256][32] __attribute__((aligned(256)));
> extern const u8 raid6_gfexp[256] __attribute__((aligned(256)));
> extern const u8 raid6_gfinv[256] __attribute__((aligned(256)));
> extern const u8 raid6_gfexi[256] __attribute__((aligned(256)));
>
>> WARNING: printk() should include KERN_ facility level
>> #120: FILE: lib/raid6/algos.c:103:
>> + printk("raid6: using %s recovery algorith\n", nest->name);
>>
>> WARNING: printk() should include KERN_ facility level
>> #122: FILE: lib/raid6/algos.c:105:
>> + printk("raid6: Yikes! No recovery algorithm found!\n");
>>
>> WARNING: printk() should include KERN_ facility level
>> #159: FILE: lib/raid6/algos.c:176:
>> + printk("raid6: Yikes! No memory available.\n");
>
> Again, these are following the conventions of the existing code such as:
>
> printk("raid6: using algorithm %s (%ld MB/s)\n",
>
> In fact, the last printk, about no memory available, was simply moved to a
> different line in my patch.
>
A lot of the RAID-6 code predates the modern kernel conventions. It
would be good to clean that up, but that is largely orthogonal to this
patch.
-hpa
prev parent reply other threads:[~2012-04-12 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 19:40 lib/raid6: SSSE3 optimized recovery functions v2 Jim Kukunas
2012-04-11 19:40 ` [PATCH 1/4] lib/raid6: fix test program build Jim Kukunas
2012-04-11 19:40 ` [PATCH 2/4] lib/raid6: Add SSSE3 optimized recovery functions Jim Kukunas
2012-04-11 19:40 ` [PATCH 3/4] lib/raid6: update test program for " Jim Kukunas
2012-04-11 19:40 ` [PATCH 4/4] lib/raid6: cleanup gen_syndrome function selection Jim Kukunas
2012-04-12 6:18 ` lib/raid6: SSSE3 optimized recovery functions v2 NeilBrown
2012-04-12 20:04 ` Jim Kukunas
2012-04-12 20:04 ` [PATCH 1/4] lib/raid6: fix test program build Jim Kukunas
2012-04-19 0:33 ` NeilBrown
2012-04-12 20:04 ` [PATCH 2/4] lib/raid6: Add SSSE3 optimized recovery functions Jim Kukunas
2012-04-12 20:04 ` [PATCH 3/4] lib/raid6: update test program for " Jim Kukunas
2012-04-12 20:04 ` [PATCH 4/4] lib/raid6: cleanup gen_syndrome function selection Jim Kukunas
2012-04-12 20:14 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87378D.7080505@zytor.com \
--to=hpa@zytor.com \
--cc=james.t.kukunas@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).