From: Randy Dunlap <rdunlap@xenotime.net>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, Tim Hockin <thockin@sun.com>
Subject: Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
Date: Mon, 16 Apr 2012 18:25:23 -0700 [thread overview]
Message-ID: <4F8CC683.7060908@xenotime.net> (raw)
In-Reply-To: <CAP=VYLr6TtABMNz1EBY2T6vYdhpR5X6S3yQTtvvqV0D7c9U5Lw@mail.gmail.com>
On 04/16/2012 03:20 PM, Paul Gortmaker wrote:
> On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
>
> Minor nit -- above line and subject reference sbc2, when fail comes
> from scb2 source module.
Ack. I noticed later that I had botched that.
Thanks.
> Paul.
> --
>
>> is not enabled, so make it depend on PCI.
>>
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>> drivers/mtd/maps/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
>> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
>> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>>
>> config MTD_SCB2_FLASH
>> tristate "BIOS flash chip on Intel SCB2 boards"
>> - depends on X86 && MTD_JEDECPROBE
>> + depends on X86 && MTD_JEDECPROBE && PCI
>> help
>> Support for treating the BIOS flash chip on Intel SCB2 boards
>> as an MTD device - with this you can reprogram your BIOS.
>> --
--
~Randy
next prev parent reply other threads:[~2012-04-16 22:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 6:11 linux-next: Tree for Apr 16 Stephen Rothwell
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
2012-04-17 1:25 ` Randy Dunlap [this message]
2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2012-04-16 19:51 ` [PATCH -next] wireless: TI wlxxx depends on MAC80211 Randy Dunlap
2012-04-17 5:30 ` Luciano Coelho
2012-04-17 18:29 ` Randy Dunlap
2012-04-17 15:52 ` Luciano Coelho
2012-05-03 12:55 ` Luciano Coelho
2012-05-10 21:25 ` Randy Dunlap
2012-05-10 21:36 ` Luciano Coelho
2012-05-10 21:37 ` Randy Dunlap
2012-05-11 11:59 ` Arend van Spriel
2012-04-17 1:01 ` [PATCH -next] staging: fix android alarm.c printk format warnings Randy Dunlap
2012-04-17 1:01 ` [PATCH -next] soc: fix printk format in soc-dapm.c Randy Dunlap
2012-04-16 22:52 ` [alsa-devel] " Fabio Estevam
2012-04-17 1:01 ` [PATCH -next] hippi: fix printk format in rrunner.c Randy Dunlap
2012-04-17 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8CC683.7060908@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=thockin@sun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).