From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556Ab2DRXtN (ORCPT ); Wed, 18 Apr 2012 19:49:13 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43218 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754093Ab2DRXtB (ORCPT ); Wed, 18 Apr 2012 19:49:01 -0400 Message-ID: <4F8F52D5.3040109@zytor.com> Date: Wed, 18 Apr 2012 16:48:37 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "H.J. Lu" CC: mingo@redhat.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/x32] x32: Fix alignment fail in struct compat_siginfo References: <1329696488-16970-1-git-send-email-hpa@zytor.com> <4F8EFE4D.2040201@zytor.com> <4F8F0385.5090901@zytor.com> <4F8F0614.9010604@zytor.com> <4F8F30F5.9030704@zytor.com> In-Reply-To: X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/2012 03:55 PM, H.J. Lu wrote: > On Wed, Apr 18, 2012 at 2:24 PM, H. Peter Anvin wrote: >> Something like this works for you? >> >> Note: we should promote __compat_[us]64 to a global type when we do the >> cleanup work requested by Linus (change __[us]64 to explicitly aligned >> types, with all users that require the old types using __compat_[us]64), >> but we need the compiler warning to do that, realistically. >> > > Can we also align struct siginfo to 8byte for x32? > We could. If we want to align the substructures then we need some major surgery to the compat_siginfo handling though. -hpa