From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Mikael Starvik <starvik@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile
Date: Thu, 19 Apr 2012 08:40:07 -0400 [thread overview]
Message-ID: <4F9007A7.9070504@windriver.com> (raw)
In-Reply-To: <20120419091450.GF16861@axis.com>
On 12-04-19 05:14 AM, Jesper Nilsson wrote:
> On Wed, Apr 18, 2012 at 09:58:43PM +0200, Paul Gortmaker wrote:
>> Most of these have been purged years ago. This one silently lived
>> on until commit 69349c2dc01c489eccaa4c472542c08e370c6d7e
>>
>> "kconfig: fix IS_ENABLED to not require all options to be defined"
>>
>> In the above, we use some macro trickery to create a conditional that
>> is valid in CPP and in C usage. However that trickery doesn't sit
>> well if you have the legacy "-traditional" flag enabled. You'll get:
>>
>> AS arch/cris/arch-v10/lib/checksum.o
>> In file included from <command-line>:4:0:
>> include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
>> make[2]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
>>
>> Everything builds fine w/o "-traditional" so simply drop it from this
>> location as well.
>>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> Agreed, I'll push this to the CRIS-tree. Thanks!
Thanks, Please make sure it goes on your "for-3.4" branch,
since Linus took the kconfig change directly into 3.4 (i.e. it
is not specific to linux-next).
Paul.
>
> /^JN - Jesper Nilsson
prev parent reply other threads:[~2012-04-19 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 19:58 [PATCH] cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile Paul Gortmaker
2012-04-19 9:14 ` Jesper Nilsson
2012-04-19 12:40 ` Paul Gortmaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9007A7.9070504@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).