From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004Ab2D2GhH (ORCPT ); Sun, 29 Apr 2012 02:37:07 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:56536 "EHLO isrv.corpit.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284Ab2D2GhE (ORCPT ); Sun, 29 Apr 2012 02:37:04 -0400 Message-ID: <4F9CE18C.2060806@msgid.tls.msk.ru> Date: Sun, 29 Apr 2012 10:37:00 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: Linus Torvalds CC: Alan Cox , Thomas Meyer , David Miller , linux-kernel@vger.kernel.org, autofs@vger.kernel.org, raven@themaw.net, stable@kernel.org Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error. References: <20120427.151433.1007849975903946491.davem@davemloft.net> <20120427.151651.2274764174217164454.davem@davemloft.net> <20120427.152404.2292425516870981391.davem@davemloft.net> <20120427234215.079a1565@pyramind.ukuu.org.uk> In-Reply-To: X-Enigmail-Version: 1.4 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.04.2012 20:10, Linus Torvalds wrote: > On Fri, Apr 27, 2012 at 4:27 PM, Linus Torvalds > wrote: >> >> The attached patch implements that, and makes autofs automatically set >> the O_DIRECT flag. > > Ok, since the packetized pipe approach makes the "compat" games in > autofs unnecessary (autofs can just always do the bigger write), I > have now reverted the commit that started this issue in my tree (and > marked it for stable). So automount should work again. > > However, I would still like to know if systemd works with the attached > patch (it's pretty much the same patch as before, but the revert made > for some changes in the autofs code). > > Thomas? I installed 32bit userspace together with systemd in a vrtual machine today, and tried it with this patch (and with the previous autofs 'fix' reverted). And no, it does not quite work. Strace shows that systemd correctly reads first 300 bytes, but next read returns 4 bytes, so it reads these and waits for next 300-4 = 296 bytes of data. /proc/1/fdinfo/16 -- the autofs pipe fd# -- shows flags=02004000 which is O_CLOEXEC|O_NONBLOCK, but this is the other end of the pipe.. shouldn't the READ side of the pipe have O_DIRECT flag now? Thanks, /mjt