From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Ulrich Drepper <drepper@akkadia.org>
Cc: arnd@arndb.de, davem@davemloft.net, hch@infradead.org,
hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org, mchehab@redhat.com,
kosaki.motohiro@gmail.com
Subject: Re: [PATCH] [RESEND] Install kernel-page-flags.h
Date: Tue, 01 May 2012 20:09:11 -0400 [thread overview]
Message-ID: <4FA07B27.70501@gmail.com> (raw)
In-Reply-To: <201204291404.q3TE4vfN023826@drepperk.user.openhosting.com>
(4/29/12 10:04 AM), Ulrich Drepper wrote:
> No one has definitely commented on this patch nor is it applied. Christoph at first said it shouldn't be done but I think he had to retract his objection. The interface is already out there. It's also IMO the right choice to go with a binary interface since there is so much data involved and the format is not tied directly to kernel-internal data structures.
>
> Could either the patch please be applied or a reason given why not?
>
>
> Signed-off-by: Ulrich Drepper<drepper@gmail.com>
>
linux/Documentation/vm/page-type.c has redundant definition of KPF_*. then, this exporting will solve it.
I'm going to ack if you can fix two things.
1) your current changelog looks like a chat log style. Please write formal changelog.
2) Please fix page-type.c too.
and pelase cc Wu Fengguang <fengguang.wu@intel.com>. His last commit explicitly says kernel-page-flags.h
was intentionally made for user space tools. see below.
commit 1a9b5b7fe0c5dad8a635288882d36785dea742f9
Author: Wu Fengguang <fengguang.wu@intel.com>
Date: Wed Dec 16 12:19:59 2009 +0100
mm: export stable page flags
Rename get_uflags() to stable_page_flags() and make it a global function
for use in the hwpoison page flags filter, which need to compare user
page flags with the value provided by user space.
Also move KPF_* to kernel-page-flags.h for use by user space tools.
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
CC: Nick Piggin <npiggin@suse.de>
CC: Christoph Lameter <cl@linux-foundation.org>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
next prev parent reply other threads:[~2012-05-02 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-29 14:04 [PATCH] [RESEND] Install kernel-page-flags.h Ulrich Drepper
2012-05-02 0:09 ` KOSAKI Motohiro [this message]
2012-05-02 14:42 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA07B27.70501@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=drepper@akkadia.org \
--cc=hch@infradead.org \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).