From: Yilu Mao <ylmao@marvell.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Lu Mao <ylmao@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"Baohua.Song@csr.com" <Baohua.Song@csr.com>,
"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>,
"robherring2@gmail.com" <robherring2@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5] ARM: cache-l2x0.c: save the final aux ctrl value for resuming
Date: Thu, 3 May 2012 21:02:56 +0800 [thread overview]
Message-ID: <4FA28200.7020508@marvell.com> (raw)
In-Reply-To: <20120503125955.GE27872@arm.com>
On 05/03/2012 08:59 PM, Catalin Marinas wrote:
> On Thu, May 03, 2012 at 01:07:37PM +0100, Yilu Mao wrote:
>> There is a bug if l2x0 controller has been enabled when calling
>> l2x0_init, the aux ctrl register will not be saved in l2x0_saved_regs.
>> Therefore we will use uninitialized l2x0_saved_regs.aux_ctrl for
>> resuming later.
>>
>> In this patch, the aux ctrl value is read and saved after it is
>> initialized. So we have the real value being set for resuming.
>>
>> Signed-off-by: Yilu Mao<ylmao@marvell.com>
>
> Acked-by: Catalin Marinas<catalin.marinas@arm.com>
Hi Catalin,
Thanks for reviewing.
I have another question:
There are a lot of registers in l2x0 controller.
Why we only save so small amount of registers?
Base on l2x0 spec, they suggest to save/restore all of them.
--
Thanks.
Best Wishes,
Yilu Mao
prev parent reply other threads:[~2012-05-03 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 12:07 [PATCH v5] ARM: cache-l2x0.c: save the final aux ctrl value for resuming Yilu Mao
2012-05-03 12:59 ` Catalin Marinas
2012-05-03 13:02 ` Yilu Mao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA28200.7020508@marvell.com \
--to=ylmao@marvell.com \
--cc=Baohua.Song@csr.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robherring2@gmail.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).