From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: mingo@elte.hu, andi@firstfloor.org, eranian@google.com,
jolsa@redhat.com, ming.m.lin@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] perf: Add Nehalem and Sandy Bridge uncore support
Date: Fri, 04 May 2012 13:47:15 +0800 [thread overview]
Message-ID: <4FA36D63.7030002@intel.com> (raw)
In-Reply-To: <1336079060.6509.17.camel@twins>
On 05/04/2012 05:04 AM, Peter Zijlstra wrote:
> On Wed, 2012-05-02 at 10:07 +0800, Yan, Zheng wrote:
>> switch (boot_cpu_data.x86_model) {
>> + case 26: /* Nehalem */
>> + case 30:
>> + case 31:
>> + case 37: /* Westmere */
>> + msr_uncores = nhm_msr_uncores;
>> + break;
>> + case 42: /* Sandy Bridge */
>> + msr_uncores = snb_msr_uncores;
>> + break;
>> default:
>> return 0;
>> }
>
> I really hate we're duplicating all these things all over the place, but
> I don't really know what to do about it either.
>
> Anyway, it looks like perf_event_intel.c is missing 31, that said I
> cannot seem to find model 31 on wikipedia either.
>
Sorry. the number 31 is copied from Lin Ming's old uncore patch. Now both
Lin Ming and I can't find the model 31 processor. I will remove the 31 in
future patches.
> What about 44, WSM-EP ?
>
> I understand NHM-EX (46) and WSM-EX (47) have different uncores not
> implemented in this series, will those follow?
Yes, I just start reading the SDM.
Regards
Yan, Zheng
next prev parent reply other threads:[~2012-05-04 5:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 2:07 [PATCH V3 0/9] perf: Intel uncore pmu counting support Yan, Zheng
2012-05-02 2:07 ` [PATCH 1/9] perf: Export perf_assign_events Yan, Zheng
2012-05-02 2:07 ` [PATCH 2/9] perf: Allow pmu to choose cpu on which to install event Yan, Zheng
2012-05-09 6:38 ` Anshuman Khandual
2012-05-10 1:09 ` Yan, Zheng
2012-05-10 3:41 ` Anshuman Khandual
2012-05-10 10:56 ` Peter Zijlstra
2012-05-02 2:07 ` [PATCH 3/9] perf: Introduce perf_pmu_migrate_context Yan, Zheng
2012-05-02 2:07 ` [PATCH 4/9] perf: Generic intel uncore support Yan, Zheng
2012-05-03 17:12 ` Peter Zijlstra
2012-05-04 7:33 ` Yan, Zheng
2012-05-04 17:57 ` Peter Zijlstra
2012-05-10 7:34 ` Yan, Zheng
2012-05-10 10:05 ` Peter Zijlstra
2012-05-11 1:54 ` Yan, Zheng
2012-05-03 21:49 ` Peter Zijlstra
2012-05-11 6:31 ` Anshuman Khandual
2012-05-11 6:41 ` Yan, Zheng
2012-05-02 2:07 ` [PATCH 5/9] perf: Add Nehalem and Sandy Bridge " Yan, Zheng
2012-05-03 21:04 ` Peter Zijlstra
2012-05-04 5:47 ` Yan, Zheng [this message]
2012-05-03 21:04 ` Peter Zijlstra
2012-05-02 2:07 ` [PATCH 6/9] perf: Generic pci uncore device support Yan, Zheng
2012-05-03 21:37 ` Peter Zijlstra
2012-05-03 21:39 ` Peter Zijlstra
2012-05-03 21:46 ` Peter Zijlstra
2012-05-04 6:07 ` Yan, Zheng
2012-05-02 2:07 ` [PATCH 7/9] perf: Add Sandy Bridge-EP uncore support Yan, Zheng
2012-05-03 21:12 ` Peter Zijlstra
2012-05-02 2:07 ` [PATCH 8/9] perf tool: Make the event parser reentrantable Yan, Zheng
2012-05-02 2:07 ` [PATCH 9/9] perf tool: Add pmu event alias support Yan, Zheng
2012-05-03 10:56 ` Jiri Olsa
2012-05-03 11:24 ` Peter Zijlstra
2012-05-03 20:05 ` Jiri Olsa
2012-05-04 12:32 ` Yan, Zheng
2012-05-07 8:34 ` Yan, Zheng
2012-05-10 9:52 ` Jiri Olsa
2012-05-07 17:14 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA36D63.7030002@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).