From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753701Ab2EDIii (ORCPT ); Fri, 4 May 2012 04:38:38 -0400 Received: from na3sys009aog119.obsmtp.com ([74.125.149.246]:60800 "EHLO na3sys009aog119.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753352Ab2EDIie (ORCPT ); Fri, 4 May 2012 04:38:34 -0400 Message-ID: <4FA3958A.4080206@ti.com> Date: Fri, 04 May 2012 11:38:34 +0300 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: Mark Brown CC: Samuel Ortiz , linux-kernel@vger.kernel.org, Misael Lopez Cruz , Benoit Cousson , devicetree-discuss@lists.ozlabs.org, Liam Girdwood Subject: Re: [PATCH 2/3] MFD: twl6040: Allocate IRQ numbers dynamically References: <1336049665-27777-1-git-send-email-peter.ujfalusi@ti.com> <1336049665-27777-3-git-send-email-peter.ujfalusi@ti.com> <20120503132004.GB14296@sirena.org.uk> <4FA2881B.6010902@ti.com> <20120503145248.GJ3955@opensource.wolfsonmicro.com> <4FA2A08C.5000403@ti.com> <20120503152643.GM3955@opensource.wolfsonmicro.com> In-Reply-To: <20120503152643.GM3955@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2012 06:26 PM, Mark Brown wrote: > On Thu, May 03, 2012 at 06:13:16PM +0300, Peter Ujfalusi wrote: >> On 05/03/2012 05:52 PM, Mark Brown wrote: >>> Are you sure there aren't any boards out there which rely on the >>> interrupt base (eg, using a GPIO with the IRQ output of a chip)? > >> Yes, I'm sure. > > Because...? The irq_base was used to map the nested interrupt numbers somewhere high enough. twl6040 has one irq line towards the CPU (comes via i2c_client->irq). With this change we just change the mapping of the nested interrupt range provided by twl6040 (instead of hardwired number we ask for suitable range). We have sdp4430 and PandaBoard with twl6040. They are fine. The other non upstream boards should be fine as well with this change. -- Péter