From: Jiri Slaby <jslaby@suse.cz>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Guy Martin <gmsof@tuxicoman.be>,
Linus Torvalds <torvalds@linux-foundation.org>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25
Date: Sat, 05 May 2012 09:39:38 +0200 [thread overview]
Message-ID: <4FA4D93A.6090103@suse.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.1205042259000.18896@file.rdu.redhat.com>
On 05/05/2012 05:04 AM, Mikulas Patocka wrote:
> Hi
>
> This patch reverts commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25.
>
> The commit 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 causes system lockup
> when pdc is used as a boot console.
>
> The kernel boots, but it locks up when transferring control to userspace
> --- the message "INIT: version 2.86 booting" is not printed and the
> computer halts. With the patch reverted, the system starts normally on
> pdc.
...
> --- a/arch/parisc/kernel/pdc_cons.c
> +++ b/arch/parisc/kernel/pdc_cons.c
...
> @@ -104,10 +103,8 @@ static int pdc_console_tty_open(struct tty_struct *tty, struct file *filp)
>
> static void pdc_console_tty_close(struct tty_struct *tty, struct file *filp)
> {
> - if (!tty->count) {
> + if (!tty->count)
Heh, I cannot find a bug in the patch proper. However this test is and
always was bogus. Does changing "!tty->count" to "tty->count == 1" help?
> del_timer_sync(&pdc_console_timer);
> - tty_port_tty_set(&tty_port, NULL);
> - }
> }
>
> static int pdc_console_tty_write(struct tty_struct *tty, const unsigned char *buf, int count)
regards,
--
js
suse labs
next prev parent reply other threads:[~2012-05-05 7:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 2:58 [PATCH] Fix compile failure on PA-RISC Mikulas Patocka
2012-05-05 3:04 ` [PATCH] Revert 5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 Mikulas Patocka
2012-05-05 7:39 ` Jiri Slaby [this message]
2012-05-05 18:44 ` Mikulas Patocka
2012-05-05 20:49 ` [PATCH 1/1] TTY: pdc_cons, fix regression in close Jiri Slaby
2012-05-05 6:55 ` [PATCH] Fix compile failure on PA-RISC Rolf Eike Beer
2012-05-05 17:09 ` Linus Torvalds
2012-05-05 18:55 ` Mikulas Patocka
2012-05-05 20:09 ` John David Anglin
2012-05-05 21:24 ` Helge Deller
2012-05-06 7:57 ` James Bottomley
2012-05-05 10:58 ` Alan Cox
2012-05-05 18:53 ` Mikulas Patocka
2012-05-05 18:55 ` Linus Torvalds
2012-05-05 22:00 ` Rolf Eike Beer
2012-05-09 3:20 ` Mikulas Patocka
2012-05-09 12:01 ` Alan Cox
2012-05-09 17:51 ` Linus Torvalds
2012-05-10 9:24 ` Geert Uytterhoeven
2012-05-06 12:24 ` Alan Cox
2012-05-09 17:38 ` Grant Grundler
2012-05-10 11:40 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4D93A.6090103@suse.cz \
--to=jslaby@suse.cz \
--cc=deller@gmx.de \
--cc=gmsof@tuxicoman.be \
--cc=jejb@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).