From: Randy Dunlap <rdunlap@xenotime.net>
To: Fengguang Wu <wfg@linux.intel.com>
Cc: Josh Triplett <josh@freedesktop.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: automated warning notifications
Date: Sat, 16 Jun 2012 10:44:21 -0700 [thread overview]
Message-ID: <4FDCC5F5.1060601@xenotime.net> (raw)
In-Reply-To: <20120616091744.GB10332@localhost>
On 06/16/2012 02:17 AM, Fengguang Wu wrote:
> On Fri, Jun 15, 2012 at 09:48:26AM -0700, Randy Dunlap wrote:
>> On 06/15/2012 01:54 AM, Fengguang Wu wrote:
>>
>>> On Fri, Jun 15, 2012 at 01:31:00AM -0700, Josh Triplett wrote:
>>>> On Fri, Jun 15, 2012 at 03:58:10PM +0800, Fengguang Wu wrote:
>>>>> On Fri, Jun 15, 2012 at 10:12:22AM +0300, Dan Carpenter wrote:
>>>>>> On Fri, Jun 15, 2012 at 09:48:35AM +0800, Fengguang Wu wrote:
>>>>>>> In an average working day, 1-2 build errors will be caught and email
>>>>>>> notified. I guess there will be more sparse warnings if it's turned
>>>>>>> on.
>>>>>>>
>>>>>>> Perhaps the sparse warnings can be enabled, but only sent to the patch
>>>>>>> author. If you and anyone else are interested, they could be sent to
>>>>>>> some mailing list, too. One thing I'm sure is, we probably never want
>>>>>>> to disturb the busy maintainers with these warnings.
>>>>>>
>>>>>> Eventually I think we will want to set up a mailing list for this or
>>>>>> we will start sending duplicate messages.
>>>>>
>>>>> Fair enough. How can we setup the mailing list? Once the list up, it
>>>>> would be trivial for me to send sparse warnings out there.
>>>>
>>>> Rather than a mailing list, how about something like test.kernel.org for
>>>> sparse warnings?
>>>
>>> It's much more trivial to send new build/sparse errors/warnings to a
>>> list than to setup a website :-) As the errors come and go every day,
>>> and they are mostly unstructured, it seems the mailing list would be a
>>> more natural fit. People can search for known errors there and/or CC
>>> fixes there.
>>>
>>> Anyway, we just sent an request for creating
>>>
>>> automated-warnings@vger.kernel.org
>>
>>
>> and you will let us know when it has been created??
>
> Well, the request has been rejected anyway..
>
>> Although I had just as soon use an existing list, like
>> kernel-janitors or kernel-testers.
>
> From http://kernelnewbies.org/KernelJanitors :
>
> Some suggestions to kernel newbies:
>
> avoid fixing compiler warnings because the goal is to fix the
> CAUSE of the warnings (which is usually not obvious), not just
> to make the warnings go away
>
> Does that suggest the commit author be the best people to fix
> warnings? The typical situation may be, the author is not aware of the
> warnings at all: they are buried in the tedious output of make...
It's a shame when a patch creates lots of warnings and they are
ignored. I would suggest that the patch should not be merged. :)
We should at least bring the warnings to the attention of the
patch author. Sure, in some cases we (I) might make a patch that
the author wouldn't want and would have better solutions for.
That's OK. It happens often. It's part of how Linux development works.
--
~Randy
next prev parent reply other threads:[~2012-06-16 17:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:25 automated warning notifications Dan Carpenter
2012-06-15 1:48 ` Fengguang Wu
2012-06-15 7:12 ` Dan Carpenter
2012-06-15 7:58 ` Fengguang Wu
2012-06-15 8:31 ` Josh Triplett
2012-06-15 8:54 ` Fengguang Wu
2012-06-15 16:48 ` Randy Dunlap
2012-06-16 9:17 ` Fengguang Wu
2012-06-16 17:44 ` Randy Dunlap [this message]
2012-06-15 10:40 ` Julia Lawall
2012-06-15 11:19 ` Dan Carpenter
2012-06-15 13:33 ` Peter Senna Tschudin
2012-06-15 13:53 ` Dan Carpenter
2012-06-15 15:49 ` Peter Senna Tschudin
2012-06-15 14:34 ` Fengguang Wu
2012-06-16 7:50 ` Cong Wang
2012-06-16 9:01 ` Fengguang Wu
2012-07-02 12:45 ` Dan Carpenter
2012-07-06 3:07 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDCC5F5.1060601@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=dan.carpenter@oracle.com \
--cc=josh@freedesktop.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=wfg@linux.intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).