From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH] sched: remove useless code in yield_to
Date: Tue, 03 Jul 2012 14:34:02 +0800 [thread overview]
Message-ID: <4FF2925A.9060005@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F262ED9.7040003@linux.vnet.ibm.com>
From: Michael Wang <wangyun@linux.vnet.ibm.com>
it's impossible to enter else branch if we have set skip_clock_update
in task_yield_fair(), as yield_to_task_fair() will directly return
true after invoke task_yield_fair().
Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
---
kernel/sched/core.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 9bb7d28..77c14aa 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4737,13 +4737,6 @@ again:
*/
if (preempt && rq != p_rq)
resched_task(p_rq->curr);
- } else {
- /*
- * We might have set it in task_yield_fair(), but are
- * not going to schedule(), so don't want to skip
- * the next update.
- */
- rq->skip_clock_update = 0;
}
out:
--
1.7.4.1
next prev parent reply other threads:[~2012-07-03 6:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 9:37 [PATCH] sched: Accelerate "pick_next_entity" under special condition Michael Wang
2012-01-16 9:50 ` Michael Wang
2012-01-16 9:51 ` Peter Zijlstra
2012-01-16 10:34 ` Michael Wang
2012-01-17 2:36 ` [PATCH v2] " Michael Wang
2012-01-17 2:41 ` Michael Wang
2012-01-17 2:58 ` Xiaotian Feng
2012-01-17 3:04 ` Michael Wang
2012-01-25 15:55 ` Peter Zijlstra
2012-01-26 10:04 ` Ingo Molnar
2012-01-27 1:22 ` Michael Wang
2012-01-27 4:42 ` Cong Wang
2012-01-29 6:32 ` Michael Wang
2012-01-29 16:33 ` Ingo Molnar
2012-01-30 3:18 ` Michael Wang
2012-01-30 3:25 ` Cong Wang
2012-01-30 5:47 ` Michael Wang
2012-07-03 6:34 ` Michael Wang [this message]
2012-07-12 5:45 ` [PATCH] sched: remove useless code in yield_to Michael Wang
2012-07-12 14:07 ` Peter Zijlstra
2012-07-12 18:44 ` Mike Galbraith
2012-07-16 2:39 ` Michael Wang
2012-08-17 6:56 ` Michael Wang
2012-08-17 9:43 ` Peter Zijlstra
2012-08-10 3:05 ` Michael Wang
2012-08-10 3:10 ` Michael Wang
2012-08-10 5:52 ` Mike Galbraith
2012-09-04 18:50 ` [tip:sched/core] sched: Remove useless code in yield_to() tip-bot for Michael Wang
2012-01-27 0:56 ` [PATCH v2] sched: Accelerate "pick_next_entity" under special condition Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF2925A.9060005@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).