From: vishnu <vravulap@amd.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>
Cc: Alexander.Deucher@amd.com, broonie@kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Colin Ian King <colin.king@canonical.com>,
YueHaibing <yuehaibing@huawei.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue.
Date: Wed, 22 Jan 2020 14:18:40 +0530 [thread overview]
Message-ID: <4a0d03a0-8cf8-8b55-0db2-4bbcb606454c@amd.com> (raw)
In-Reply-To: <87d0bcmjob.wl-kuninori.morimoto.gx@renesas.com>
On 22/01/20 5:44 AM, Kuninori Morimoto wrote:
>
> Hi Ravulapati
>
>> If we play audio back to back, which kills one playback
>> and immediately start another, we can hear clicks.
>> This patch fixes the issue.
>>
>> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
>> ---
> (snip)
>> + kfree(rtd);
>
> Please double check soc_new_pcm_runtime() and
> soc_free_pcm_runtime() at soc-core.c.
> Because rtd is created via devm_kzalloc(),
> and has many related resources which need to be cared when rtd was freed.
> Just kfree() is not good/enough, I think.
>
> I think you want to use is snd_soc_remove_pcm_runtime()
> instead of kfree()
>
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
>
I will create a separate patch for kfree and separate one for subsequent
play back issue.
next prev parent reply other threads:[~2020-01-22 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 10:43 [PATCH] ASoC: amd: Fix for Subsequent Playback issue Ravulapati Vishnu vardhan rao
2020-01-21 16:59 ` Mark Brown
[not found] ` <DM6PR12MB3868B9744A40D41450155534E70D0@DM6PR12MB3868.namprd12.prod.outlook.com>
2020-01-21 17:08 ` Mark Brown
[not found] ` <DM6PR12MB386893EE3876B51B35A1787BE70D0@DM6PR12MB3868.namprd12.prod.outlook.com>
2020-01-21 17:26 ` Mark Brown
[not found] ` <87d0bcmjob.wl-kuninori.morimoto.gx@renesas.com>
2020-01-22 8:48 ` vishnu [this message]
2020-01-27 11:26 Ravulapati Vishnu vardhan rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a0d03a0-8cf8-8b55-0db2-4bbcb606454c@amd.com \
--to=vravulap@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).