From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbcIHMuq (ORCPT ); Thu, 8 Sep 2016 08:50:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:52956 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbcIHMup (ORCPT ); Thu, 8 Sep 2016 08:50:45 -0400 Subject: Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible To: Neil Armstrong References: <1473321206-32284-1-git-send-email-narmstrong@baylibre.com> <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, carlo@caione.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <4a199a95-3ee6-a3a0-bc8a-63bd0912e7d2@suse.de> Date: Thu, 8 Sep 2016 14:50:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <293061a8-e867-4d91-20cb-6e5df8e9b543@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 08.09.2016 um 14:04 schrieb Andreas Färber: > Am 08.09.2016 um 09:53 schrieb Neil Armstrong: >> This patchset adds a specific compatible string in the Meson SPIFC driver for >> the Amlogic Meson GXBB SoC. > > Any particular reason? We could just reuse the meson6 one since there > appear to be no code changes so far. So Neil is essentially telling me they don't know whether there are any differences in the IP block, so a separate compatible string was chosen. No objection from my side, but a general clarification from device tree maintainers when and when not to would be appreciated. (+ devicetree) Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)