From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537F9C10F25 for ; Sun, 8 Mar 2020 02:09:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B754206D7 for ; Sun, 8 Mar 2020 02:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726289AbgCHCI2 (ORCPT ); Sat, 7 Mar 2020 21:08:28 -0500 Received: from mga03.intel.com ([134.134.136.65]:38144 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbgCHCI2 (ORCPT ); Sat, 7 Mar 2020 21:08:28 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2020 18:08:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,528,1574150400"; d="scan'208";a="414402899" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.211.93]) ([10.254.211.93]) by orsmga005.jf.intel.com with ESMTP; 07 Mar 2020 18:08:23 -0800 Cc: baolu.lu@linux.intel.com, Joerg Roedel , ashok.raj@intel.com, jacob.jun.pan@linux.intel.com, kevin.tian@intel.com, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Daniel Drake , Derrick Jonathan , Jerry Snitselaar , Robin Murphy , Sai Praneeth Prakhya Subject: Re: [PATCH 1/6] iommu: Add dev_def_domain_type() callback in iommu_ops To: Christoph Hellwig References: <20200307062014.3288-1-baolu.lu@linux.intel.com> <20200307062014.3288-2-baolu.lu@linux.intel.com> <20200307141836.GA26190@lst.de> From: Lu Baolu Message-ID: <4a4a04aa-7fb5-88c9-2b4d-ee4f3568944b@linux.intel.com> Date: Sun, 8 Mar 2020 10:08:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200307141836.GA26190@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, Thanks for your review. On 2020/3/7 22:18, Christoph Hellwig wrote: > Do we really need the dev_ prefix in the method name? Shouldn't the > struct device parameter be hint enough? Fair enough. Will use def_domain_type(). Best regards, baolu