From: Florian Fainelli <f.fainelli@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
"supporter:QLOGIC QL41xxx ISCSI DRIVER"
<GR-QLogic-Storage-Upstream@marvell.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"open list:QLOGIC QL41xxx ISCSI DRIVER"
<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting
Date: Mon, 29 Nov 2021 20:09:55 -0800 [thread overview]
Message-ID: <4a61707b-a82b-4950-88b3-5f268d9fc92c@gmail.com> (raw)
In-Reply-To: <yq1fsrez4cn.fsf@ca-mkp.ca.oracle.com>
On 11/29/2021 7:59 PM, Martin K. Petersen wrote:
>
> Florian,
>
>> The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the
>> following warning:
>>
>> drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type
>> 'char' but the argument has type 'int' [-Wformat]
>> rc = snprintf(buf, 3, "%hhd\n",
>> SYSFS_FLAG_FW_SEL_BOOT);
>>
>> Fix this to cast the constant as an u8 since the intention is to print
>> it via sysfs as a byte.
>
> The other occurrences of SYSFS_FLAG_FW_SEL_BOOT use "%d". Since %hh is
> deprecated I suggest you just fix the snprintf().
That was what v1 did here:
https://lkml.org/lkml/2021/11/26/9
however Manish seemed to want that flag to be printed as a byte I am
fine either way.
--
Florian
next prev parent reply other threads:[~2021-11-30 4:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 20:17 [PATCH v2 0/2] scsi: qedi: Couple of warning fixes Florian Fainelli
2021-11-26 20:17 ` [PATCH v2 1/2] scsi: qedi: Remove set but unused 'page' variable Florian Fainelli
2021-11-30 4:00 ` Martin K. Petersen
2021-11-26 20:17 ` [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting Florian Fainelli
2021-11-29 7:29 ` [EXT] " Manish Rangankar
2021-11-30 3:59 ` Martin K. Petersen
2021-11-30 4:09 ` Florian Fainelli [this message]
2021-11-30 4:25 ` Martin K. Petersen
2021-12-03 3:03 ` [PATCH v2 0/2] scsi: qedi: Couple of warning fixes Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a61707b-a82b-4950-88b3-5f268d9fc92c@gmail.com \
--to=f.fainelli@gmail.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).