From: Pu Wen <puwen@hygon.cn>
To: Borislav Petkov <bp@alien8.de>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] x86/cpu/hygon: Fix phys_proc_id calculation logic for multi-die processor
Date: Sat, 23 Mar 2019 09:48:52 +0800 [thread overview]
Message-ID: <4a61a541-59fb-21f0-6e7f-cc9f045e190c@hygon.cn> (raw)
In-Reply-To: <20190322164445.GG12472@zn.tnic>
On 2019/3/23 0:44, Borislav Petkov wrote:
> On Sat, Mar 23, 2019 at 12:19:01AM +0800, Pu Wen wrote:
>> That 6 is not a magic number.
>
> Well, if I see a naked 6, then it is only magic to me. Now if it were a
> proper define with a descriptive name...
So maybe define it as:
#define APICID_SOCKET_ID BIT(6)
--
Regards,
Pu Wen
next prev parent reply other threads:[~2019-03-23 1:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 10:43 [RFC PATCH] x86/cpu/hygon: Fix phys_proc_id calculation logic for multi-die processor Pu Wen
2019-03-22 15:54 ` Borislav Petkov
2019-03-22 16:19 ` Pu Wen
2019-03-22 16:44 ` Borislav Petkov
2019-03-22 16:52 ` Peter Zijlstra
2019-03-23 3:00 ` Pu Wen
2019-03-23 1:48 ` Pu Wen [this message]
2019-03-23 8:57 ` Borislav Petkov
2019-03-22 17:16 ` Borislav Petkov
2019-03-23 2:13 ` Pu Wen
2019-03-23 8:59 ` Borislav Petkov
2019-03-23 10:56 ` Pu Wen
2019-03-23 11:08 ` Borislav Petkov
2019-03-23 11:11 ` Pu Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a61a541-59fb-21f0-6e7f-cc9f045e190c@hygon.cn \
--to=puwen@hygon.cn \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).