From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754652AbdBPMgC (ORCPT ); Thu, 16 Feb 2017 07:36:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:53956 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbdBPMgA (ORCPT ); Thu, 16 Feb 2017 07:36:00 -0500 Subject: Re: [PATCH 13/17] md: raid1: use bio_segments_all() To: Ming Lei , Shaohua Li , Jens Axboe , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , NeilBrown References: <1487245547-24384-1-git-send-email-tom.leiming@gmail.com> <1487245547-24384-14-git-send-email-tom.leiming@gmail.com> From: Johannes Thumshirn Message-ID: <4a700de4-8540-d5d8-8c58-3465c0a7a55a@suse.de> Date: Thu, 16 Feb 2017 13:35:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1487245547-24384-14-git-send-email-tom.leiming@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/16/2017 12:45 PM, Ming Lei wrote: > @@ -998,7 +998,8 @@ static void alloc_behind_pages(struct bio *bio, struct r1bio *r1_bio) > { > int i; > struct bio_vec *bvec; > - struct bio_vec *bvecs = kzalloc(bio->bi_vcnt * sizeof(struct bio_vec), > + unsigned vcnt = bio_segments_all(bio); > + struct bio_vec *bvecs = kzalloc(vcnt * sizeof(struct bio_vec), > GFP_NOIO); Maybe use kcalloc() instead of kzalloc() with a multiplication. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850