linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sibi Sankar <sibis@codeaurora.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: robh+dt@kernel.org, bjorn.andersson@linaro.org,
	agross@kernel.org, mark.rutland@arm.com,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org
Subject: Re: [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs
Date: Thu, 29 Aug 2019 08:08:06 +0530	[thread overview]
Message-ID: <4a71d26db054be636e57c4d031b0d3ec@codeaurora.org> (raw)
In-Reply-To: <1566808568.3842.2.camel@pengutronix.de>

Hey Philipp,
Thanks for the review!

On 2019-08-26 14:06, Philipp Zabel wrote:
> On Sat, 2019-08-24 at 20:54 +0530, Sibi Sankar wrote:
>> Add SC7180 AOSS reset to the list of possible bindings.
>> 
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt 
>> b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> index 510c748656ec5..3eb6a22ced4bc 100644
>> --- a/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> +++ b/Documentation/devicetree/bindings/reset/qcom,aoss-reset.txt
>> @@ -8,8 +8,8 @@ Required properties:
>>  - compatible:
>>  	Usage: required
>>  	Value type: <string>
>> -	Definition: must be:
>> -		    "qcom,sdm845-aoss-cc"
>> +	Definition: must be one of:
>> +		"qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
> 
> Should this emphasize that the common sdm845 compatible always has to 
> be
> included?
> 
> +	Definition: must be:
> +		"qcom,sdm845-aoss-cc" for SDM845 or

can we drop the "or" since
we would need to keep adding
it in the future.

> +		"qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc" for SC7180

I prefer ^^ approach for the
reasons stated below.

> 
> or like the qcom,kpss-gcc bindings:
> 
> +	Definition: should be one of the following. The generic
> compatible
> +		"qcom,sdm845-aoss-cc" should also be
> included.
> +		"qcom,sc7180-aoss-cc", "qcom,sdm845-aoss-cc"
> +

It is extremely unlikely that
future SoCs would maintain same
number of reset lines/offsets
due to the constant flux in
remote processors being added
to the SoCs. So a generic
compatible might not make sense
here.

> 	"qcom,sdm845-aoss-cc"
> 
> regards
> Philipp

-- 
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.

  reply	other threads:[~2019-08-29 17:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-24 15:24 [RESEND PATCH v2 0/2] Add PDC Global and AOSS reset support Sibi Sankar
2019-08-24 15:24 ` [RESEND PATCH v2 1/2] dt-bindings: reset: aoss: Add AOSS reset binding for SC7180 SoCs Sibi Sankar
2019-08-26  8:36   ` Philipp Zabel
2019-08-29  2:38     ` Sibi Sankar [this message]
2019-08-30  5:32   ` Stephen Boyd
2019-08-30 18:34     ` Sibi Sankar
2019-08-24 15:24 ` [RESEND PATCH v2 2/2] dt-bindings: reset: pdc: Add PDC Global " Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a71d26db054be636e57c4d031b0d3ec@codeaurora.org \
    --to=sibis@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).