From: Benjamin Berg <bberg@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs
Date: Mon, 07 Jun 2021 22:09:58 +0200 [thread overview]
Message-ID: <4a76d2152f016b58298bec16aa2003a6ec55f8a8.camel@redhat.com> (raw)
In-Reply-To: <20210607131442.20121-1-heikki.krogerus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
Hi Heikki,
On Mon, 2021-06-07 at 16:14 +0300, Heikki Krogerus wrote:
> This is the RFC series I promised [1].
Cool.
> I'm sorry it took this long to prepare these. I had to concentrate on
> other task for a while.
>
> Let me know if you still see any problems.
Hmm, I am not sure this got better. I applied the patchset on top of of
the 5.12.9 Fedora 34 kernel. On the machine in question (X1 Carbon 8),
I see the online state getting stuck at 1 occasionally. This can happen
for example when quickly plugging and unplugging a USB-C charger.
Benjamin
> [1]
> https://lore.kernel.org/linux-usb/YKT3oEt%2F9fX8k8mw@kuha.fi.intel.com/
>
> thanks,
>
> Heikki Krogerus (7):
> usb: typec: ucsi: Always cancel the command if PPM reports BUSY
> condition
> usb: typec: ucsi: Don't stop alt mode registration on busy
> condition
> usb: typec: ucsi: Add poll worker for alternate modes
> usb: typec: ucsi: acpi: Reduce the command completion timeout
> usb: typec: ucsi: Process every connector change as unique
> connector
> state
> usb: typec: ucsi: Filter out spurious events
> usb: typec: ucsi: Read the PDOs in separate work
>
> drivers/usb/typec/ucsi/ucsi.c | 317 ++++++++++++++++-----------
> --
> drivers/usb/typec/ucsi/ucsi.h | 3 +-
> drivers/usb/typec/ucsi/ucsi_acpi.c | 2 +-
> 3 files changed, 183 insertions(+), 139 deletions(-)
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-07 20:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 13:14 [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 1/7] usb: typec: ucsi: Always cancel the command if PPM reports BUSY condition Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 2/7] usb: typec: ucsi: Don't stop alt mode registration on busy condition Heikki Krogerus
2021-06-08 9:31 ` Sergei Shtylyov
2021-06-08 13:18 ` Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 3/7] usb: typec: ucsi: Add poll worker for alternate modes Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 4/7] usb: typec: ucsi: acpi: Reduce the command completion timeout Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 5/7] usb: typec: ucsi: Process every connector change as unique connector state Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 6/7] usb: typec: ucsi: Filter out spurious events Heikki Krogerus
2021-06-07 13:14 ` [RFC PATCH 7/7] usb: typec: ucsi: Read the PDOs in separate work Heikki Krogerus
2021-06-07 20:09 ` Benjamin Berg [this message]
2021-06-08 6:42 ` [RFC PATCH 0/7] usb: typec: ucsi: Polling the alt modes and PDOs Heikki Krogerus
2021-06-08 6:54 ` Heikki Krogerus
2021-06-08 19:32 ` Benjamin Berg
2021-06-09 11:25 ` Heikki Krogerus
2021-06-09 12:18 ` Heikki Krogerus
2021-06-09 12:56 ` Heikki Krogerus
2021-06-09 17:39 ` Benjamin Berg
2021-06-10 12:07 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a76d2152f016b58298bec16aa2003a6ec55f8a8.camel@redhat.com \
--to=bberg@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).