From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98A1EC4360F for ; Thu, 4 Apr 2019 03:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 556102054F for ; Thu, 4 Apr 2019 03:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JclFOHw1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728879AbfDDDyE (ORCPT ); Wed, 3 Apr 2019 23:54:04 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36754 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728159AbfDDDyD (ORCPT ); Wed, 3 Apr 2019 23:54:03 -0400 Received: by mail-wr1-f67.google.com with SMTP id y13so1673905wrd.3; Wed, 03 Apr 2019 20:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=QFJKbWwJQQQ7V06d4lRG1uvlxvhZkuGjI8ArljGfDMU=; b=JclFOHw1VPKf0YwJKCIOCw/JQsIYr/Fve2EHcK/4EAXRHoz0VMz5fx8F0A/9uwDsyX ip3UY248Z5wj3jWdjyspxboc7CRikTOcp8ZV07D7MnKrjN1eOUOBjDbjMiROE1rvkyFu +D52uCbTKB6z369UZjXI21bfDMuGH/9WgJWakw/rlBawRCENYjDQ/fKl3YaBQ6V+sxbl zoCZgcZF3eiKKsp0+c2tSwk3296m0oT790Wuro/6hLhDih7wnsV+z9ixzLX0W3oev4Lk ILnc7qKdjAwmooSLP3uyC3k0f6w+rZVKDzWP3r7p1tcOVmB0QgD8kseQnqlwrMBD4LNH o5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QFJKbWwJQQQ7V06d4lRG1uvlxvhZkuGjI8ArljGfDMU=; b=fTQNDH9ho7JvtGIJ9eZmDbppP2k9hXvUbdDc6694OWWpXr5Wpn5jo8k7+FHNhYjnjS qN0zJoe7t0k/1ZhhvMtiz3Kg2bxhmuXnKyVrdfWTVLhKHgksG/Hczy6v85zCPsI3Wy2c 6nB9YXxhH/Rk+1tbdJpb8JVuhPY/k4djiKQ8jMVfa9tEUB9MbLB9GdfFpUxfmF9SJmJJ icKAUjSWyPaGDZqiRZoQiCDfll/OxYzp3vDg4QWfxSvCNAYF122GV4xGUTOXJdf01Ofu Jo9xrCLJfzygXP45EEj7Uo/Ao8u0fMtveWpCpEjN+dGkLKZX72yBLQL86h7aUHA/slX2 OZsg== X-Gm-Message-State: APjAAAX7oLRxX7mtLSlU6NAQv+MwjMikgeYRD4CbaOk5GuHJdmbxGKay 5+uTPhlLBPMlm6WHDBYTZGc= X-Google-Smtp-Source: APXvYqyy2JUDQ7j9DATBxALbaFBEfxT6lzvoJ1Z8dh9lIzree4jMXcKYdpthri0NfL9YVIuzYn1img== X-Received: by 2002:a5d:6b04:: with SMTP id v4mr1063731wrw.69.1554350040620; Wed, 03 Apr 2019 20:54:00 -0700 (PDT) Received: from [192.168.8.147] (133.85.136.77.rev.sfr.net. [77.136.85.133]) by smtp.gmail.com with ESMTPSA id g3sm12713419wmk.32.2019.04.03.20.53.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 20:53:59 -0700 (PDT) Subject: Re: kernel BUG at net/core/net-sysfs.c:LINE! To: "wanghai (M)" , syzbot , alexander.h.duyck@intel.com, amritha.nambiar@intel.com, andriy.shevchenko@linux.intel.com, davem@davemloft.net, dmitry.torokhov@gmail.com, f.fainelli@gmail.com, idosch@mellanox.com, joe@perches.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, stephen@networkplumber.org, syzkaller-bugs@googlegroups.com, tyhicks@canonical.com, yuehaibing@huawei.com, gregkh@linuxfoundation.org References: <000000000000e644ba0584bdf7e8@google.com> <79eff7ec-4127-e58c-bf11-ade3b482fb43@huawei.com> From: Eric Dumazet Message-ID: <4a76e24c-41c0-cadb-cb4d-a7e0f57e212c@gmail.com> Date: Wed, 3 Apr 2019 20:53:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <79eff7ec-4127-e58c-bf11-ade3b482fb43@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2019 08:19 PM, wanghai (M) wrote: > Can someone fix this issue? Thanks. What do you mean by this exactly ? It seems your patch added a regression, so you should either revert the patch or fix this yourself. > > 在 2019/3/23 15:32, syzbot 写道: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:    e382d91f Add linux-next specific files for 20190322 >> git tree:       linux-next >> console output: https://syzkaller.appspot.com/x/log.txt?x=1737671b200000 >> kernel config: https://syzkaller.appspot.com/x/.config?x=3d850e8b394c7a19 >> dashboard link: https://syzkaller.appspot.com/bug?extid=6024817a931b2830bc93 >> compiler:       gcc (GCC) 9.0.0 20181231 (experimental) >> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1795613b200000 >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10f5a437200000 >> >> The bug was bisected to: >> >> commit 6b70fc94afd165342876e53fc4b2f7d085009945 >> Author: Wang Hai >> Date:   Wed Mar 20 18:25:05 2019 +0000 >> >>     net-sysfs: Fix memory leak in netdev_register_kobject >> >> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1522556d200000 >> final crash: https://syzkaller.appspot.com/x/report.txt?x=1722556d200000 >> console output: https://syzkaller.appspot.com/x/log.txt?x=1322556d200000 >> >> IMPORTANT: if you fix the bug, please add the following tag to the commit: >> Reported-by: syzbot+6024817a931b2830bc93@syzkaller.appspotmail.com >> Fixes: 6b70fc94afd1 ("net-sysfs: Fix memory leak in netdev_register_kobject") >> >> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000441399 >> RDX: 0000000020000080 RSI: 00000000000089f1 RDI: 0000000000000006 >> RBP: 00007ffcd20666d0 R08: 0000000000000001 R09: 0000000000000000 >> R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff >> R13: 0000000000000007 R14: 0000000000000000 R15: 0000000000000000 >> ------------[ cut here ]------------ >> kernel BUG at net/core/net-sysfs.c:1631! >> invalid opcode: 0000 [#1] PREEMPT SMP KASAN >> CPU: 1 PID: 8035 Comm: syz-executor344 Not tainted 5.1.0-rc1-next-20190322 #9 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >> RIP: 0010:netdev_release net/core/net-sysfs.c:1631 [inline] >> RIP: 0010:netdev_release+0x92/0xb0 net/core/net-sysfs.c:1627 >> Code: 48 c1 ea 03 80 3c 02 00 75 29 48 8b bb 80 fa ff ff e8 12 77 20 fc 4c 89 ef e8 7a cc f5 ff 5b 41 5c 41 5d 5d c3 e8 9e 9b e8 fb <0f> 0b e8 27 b1 20 fc eb 9c e8 80 b1 20 fc eb d0 0f 1f 40 00 66 2e >> RSP: 0018:ffff88808d6af718 EFLAGS: 00010293 >> RAX: ffff8880a87902c0 RBX: ffff88808e3612a0 RCX: ffffffff8587fc89 >> RDX: 0000000000000000 RSI: ffffffff8587fcd2 RDI: 0000000000000001 >> RBP: ffff88808d6af730 R08: ffff8880a87902c0 R09: ffff8880a8790b60 >> R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 >> R13: ffff88808e360d00 R14: 0000000000000000 R15: 0000000000000000 >> FS:  0000000001752880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 >> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000000000000000 CR3: 0000000098da2000 CR4: 00000000001406e0 >> Call Trace: >>  device_release+0x7d/0x210 drivers/base/core.c:1064 >>  kobject_cleanup lib/kobject.c:662 [inline] >>  kobject_release lib/kobject.c:691 [inline] >>  kref_put include/linux/kref.h:67 [inline] >>  kobject_put.cold+0x28f/0x2ec lib/kobject.c:708 >>  put_device+0x20/0x30 drivers/base/core.c:2205 >>  netdev_register_kobject+0x1a1/0x3c0 net/core/net-sysfs.c:1763 >>  register_netdevice+0x878/0xff0 net/core/dev.c:8709 >>  ip6_tnl_create2+0x1c2/0x350 net/ipv6/ip6_tunnel.c:269 >>  ip6_tnl_create net/ipv6/ip6_tunnel.c:320 [inline] >>  ip6_tnl_locate+0x63f/0x8d0 net/ipv6/ip6_tunnel.c:368 >>  ip6_tnl_ioctl+0x490/0xab0 net/ipv6/ip6_tunnel.c:1634 >>  dev_ifsioc+0x257/0x990 net/core/dev_ioctl.c:322 >>  dev_ioctl+0x286/0xc90 net/core/dev_ioctl.c:513 >>  sock_ioctl+0x48b/0x610 net/socket.c:1102 >>  vfs_ioctl fs/ioctl.c:46 [inline] >>  file_ioctl fs/ioctl.c:509 [inline] >>  do_vfs_ioctl+0xd6e/0x1390 fs/ioctl.c:696 >>  ksys_ioctl+0xab/0xd0 fs/ioctl.c:713 >>  __do_sys_ioctl fs/ioctl.c:720 [inline] >>  __se_sys_ioctl fs/ioctl.c:718 [inline] >>  __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:718 >>  do_syscall_64+0x103/0x610 arch/x86/entry/common.c:290 >>  entry_SYSCALL_64_after_hwframe+0x49/0xbe >> RIP: 0033:0x441399 >> Code: e8 5c ae 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 bb 0a fc ff c3 66 2e 0f 1f 84 00 00 00 00 >> RSP: 002b:00007ffcd20666b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 >> RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000441399 >> RDX: 0000000020000080 RSI: 00000000000089f1 RDI: 0000000000000006 >> RBP: 00007ffcd20666d0 R08: 0000000000000001 R09: 0000000000000000 >> R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff >> R13: 0000000000000007 R14: 0000000000000000 R15: 0000000000000000 >> Modules linked in: >> ---[ end trace 0dbf190846958075 ]--- >> RIP: 0010:netdev_release net/core/net-sysfs.c:1631 [inline] >> RIP: 0010:netdev_release+0x92/0xb0 net/core/net-sysfs.c:1627 >> Code: 48 c1 ea 03 80 3c 02 00 75 29 48 8b bb 80 fa ff ff e8 12 77 20 fc 4c 89 ef e8 7a cc f5 ff 5b 41 5c 41 5d 5d c3 e8 9e 9b e8 fb <0f> 0b e8 27 b1 20 fc eb 9c e8 80 b1 20 fc eb d0 0f 1f 40 00 66 2e >> RSP: 0018:ffff88808d6af718 EFLAGS: 00010293 >> RAX: ffff8880a87902c0 RBX: ffff88808e3612a0 RCX: ffffffff8587fc89 >> RDX: 0000000000000000 RSI: ffffffff8587fcd2 RDI: 0000000000000001 >> RBP: ffff88808d6af730 R08: ffff8880a87902c0 R09: ffff8880a8790b60 >> R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 >> R13: ffff88808e360d00 R14: 0000000000000000 R15: 0000000000000000 >> FS:  0000000001752880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 >> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >> CR2: 0000000000000000 CR3: 0000000098da2000 CR4: 00000000001406e0 >> >> >> --- >> This bug is generated by a bot. It may contain errors. >> See https://goo.gl/tpsmEJ for more information about syzbot. >> syzbot engineers can be reached at syzkaller@googlegroups.com. >> >> syzbot will keep track of this bug report. See: >> https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >> For information about bisection process see: https://goo.gl/tpsmEJ#bisection >> syzbot can test patches for this bug, for details see: >> https://goo.gl/tpsmEJ#testing-patches >> >> . >> >