From: Colin Ian King <colin.king@canonical.com>
To: shuah <shuah@kernel.org>, Andy Lutomirski <luto@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
Date: Tue, 2 Jul 2019 23:50:31 +0100 [thread overview]
Message-ID: <4a82a57a-9f36-d525-6271-4da01bfd5241@canonical.com> (raw)
In-Reply-To: <aec8c4b5-a82a-74c0-f60f-869786e4a2fa@kernel.org>
On 02/07/2019 23:48, shuah wrote:
> On 7/2/19 4:42 PM, Colin Ian King wrote:
>> On 02/07/2019 20:25, shuah wrote:
>>> On 7/2/19 8:22 AM, shuah wrote:
>>>> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>>>>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com>
>>>>> wrote:
>>>>>>
>>>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>>>
>>>>>> There is an spelling mistake in an a test error message. Fix it.
>>>>>>
>>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>>>> ---
>>>>>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>>>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>>>>> printf("[OK]\tExecuting the vsyscall page failed:
>>>>>> #PF(0x%lx)\n",
>>>>>> segv_err);
>>>>>> } else {
>>>>>> - printf("[FAILT]\tExecution failed with the wrong
>>>>>> error: #PF(0x%lx)\n",
>>>>>> + printf("[FAIL]\tExecution failed with the wrong
>>>>>> error: #PF(0x%lx)\n",
>>>>>> segv_err);
>>>>>> return 1;
>>>>>> }
>>>>>> --
>>>>>> 2.20.1
>>>>>>
>>>>>
>>>>> Acked-by: Andy Lutomirski <luto@kernel.org>
>>>>>
>>>>
>>>> Thanks Andy!
>>>>
>>>> I will queue this up for 5.3
>>>>
>>>> -- Shuah
>>>>
>>>
>>> Hi Colin,
>>>
>>> Checkpatch warning on this. Probably failed on the original patch.
>>> Could you please fix the checkpatch warn, and send v2.
>>
>> If I split the line, I get another checkpatch warning:
>>
>> "WARNING: quoted string split across lines"
>>
>> Either way checkpatch emits a warning. The convention is to not break
>> literal strings, and the line is only a few chars over the 80 char
>> boundary, so the V1 of the patch is the way it should be IMHO.
>>
>
> As such this existed before your patch. I will apply v1.
Cool, thanks Shuah.
>
> thanks,
> -- Shuah
prev parent reply other threads:[~2019-07-03 0:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 13:04 [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" Colin King
2019-07-01 13:12 ` walter harms
2019-07-01 17:59 ` shuah
2019-07-01 17:48 ` Andy Lutomirski
2019-07-02 14:22 ` shuah
2019-07-02 19:25 ` shuah
2019-07-02 22:42 ` Colin Ian King
2019-07-02 22:48 ` shuah
2019-07-02 22:50 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a82a57a-9f36-d525-6271-4da01bfd5241@canonical.com \
--to=colin.king@canonical.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).