From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>, kgunda@codeaurora.org
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org
Subject: Re: [PATCH v3 07/11] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device
Date: Mon, 4 Nov 2019 11:40:18 +0530 [thread overview]
Message-ID: <4a8801c0-97a3-69f9-abf7-4a74c90d40a3@codeaurora.org> (raw)
In-Reply-To: <5db9a00d.1c69fb81.c3df6.04eb@mx.google.com>
On 10/30/2019 8:07 PM, Stephen Boyd wrote:
> Quoting kgunda@codeaurora.org (2019-10-29 23:06:43)
>> On 2019-10-29 22:11, Stephen Boyd wrote:
>>> Quoting Rajendra Nayak (2019-10-23 02:02:15)
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>>> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>>> index 04808a07d7da..6584ac6e6c7b 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>>>> @@ -224,6 +224,25 @@
>>>> };
>>>> };
>>>>
>>>> + spmi_bus: spmi@c440000 {
>>>> + compatible = "qcom,spmi-pmic-arb";
>>>> + reg = <0 0xc440000 0 0x1100>,
>>>
>>> Please pad out the registers to 8 numbers. See sdm845.
>> Ok.. Will address it in the next series.
>>>
>>>> + <0 0xc600000 0 0x2000000>,
>>>> + <0 0xe600000 0 0x100000>,
>>>> + <0 0xe700000 0 0xa0000>,
>>>> + <0 0xc40a000 0 0x26000>;
>>>> + reg-names = "core", "chnls", "obsrvr", "intr",
>>>> "cnfg";
>>>> + interrupt-names = "periph_irq";
>>>> + interrupts-extended = <&pdc 1
>>>> IRQ_TYPE_LEVEL_HIGH>;
>>>
>>> This is different than sdm845. I guess pdc is working?
>>>
>> Yes. For SDM845 pdc controller support was not yet added. That's why
>> still the GIC interrupt is used.
>> Where as for SC7180 the same is added with
>> https://lore.kernel.org/patchwork/patch/1143335/.
>>
>> Yes. pdc is working.
>
> Cool. The patch that adds pdc to the DT should come before this one
> then. In reality, it would be better if it was all squashed down into
> one big commit that just introduces the SoC file and one commit for
> PMICs and then one commit for the idp board. Then we don't have this
> ordering problem.
I'll fix the ordering issues when I respin.
I could squash all of the patches touching the SoC dtsi, but given the
authorship for each varies, I will keep it as is perhaps.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-11-04 6:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:02 [PATCH v3 00/11] Add device tree support for sc7180 Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 01/11] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-25 19:50 ` Rob Herring
2019-11-04 6:03 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 02/11] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-29 16:49 ` Stephen Boyd
2019-11-04 6:15 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 03/11] dt-bindings: arm-smmu: update binding for qcom sc7180 SoC Rajendra Nayak
2019-10-25 19:51 ` Rob Herring
2019-11-04 6:04 ` Rajendra Nayak
2019-10-29 16:42 ` Stephen Boyd
2019-11-04 6:11 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 04/11] arm64: dts: sc7180: Add device node for apps_smmu Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 05/11] arm64: dts: qcom: sc7180: Add cmd_db reserved area Rajendra Nayak
2019-10-23 12:16 ` Sibi Sankar
2019-10-24 2:30 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 06/11] arm64: dts: qcom: sc7180: Add rpmh-rsc node Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 07/11] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device Rajendra Nayak
2019-10-29 16:41 ` Stephen Boyd
2019-10-30 6:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd
2019-11-04 6:10 ` Rajendra Nayak [this message]
2019-10-23 9:02 ` [PATCH v3 08/11] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals Rajendra Nayak
2019-10-29 16:38 ` Stephen Boyd
2019-10-30 7:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd
2019-10-23 9:02 ` [PATCH v3 09/11] arm64: dts: qcom: sc7180-idp: Add RPMh regulators Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 10/11] arm64: dts: qcom: SC7180: Add node for rpmhcc clock driver Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller Rajendra Nayak
2019-10-25 19:47 ` Matthias Kaehlcke
2019-11-04 6:03 ` Rajendra Nayak
2019-10-29 16:50 ` Stephen Boyd
2019-10-30 19:50 ` Matthias Kaehlcke
2019-11-04 6:17 ` Rajendra Nayak
2019-11-04 6:33 ` Bjorn Andersson
2019-11-04 6:56 ` Rajendra Nayak
2019-11-04 7:10 ` Bjorn Andersson
2019-11-05 0:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8801c0-97a3-69f9-abf7-4a74c90d40a3@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).