From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB03CC432BE for ; Fri, 27 Aug 2021 04:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE86E60F4A for ; Fri, 27 Aug 2021 04:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234459AbhH0EJL (ORCPT ); Fri, 27 Aug 2021 00:09:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234291AbhH0EJJ (ORCPT ); Fri, 27 Aug 2021 00:09:09 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 479B3C061757; Thu, 26 Aug 2021 21:08:21 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id c12so9112210ljr.5; Thu, 26 Aug 2021 21:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=V1I4L+WuQcg7nWDY9KXq21TZu2GnKesC/k47Saxr6QE=; b=fvxGy3KeiW5F1WxZjJBhdz8dmeqbJ+TxHhoj24arnoPWM1erBG4dUf/34j3vnKxEya KbylsG3L/RjG5QPagD5JWYMwIZgORVLRcYFPapM3f95IW3i3kpDuwO9ea9q0sgdTHDWn QB0nDotBPb9jehl0SgNToLoTc6H4NWwaTI/IwviUuW1PlfNFQpan7rD+6aZuxKIDRvni esAAfvnR8hhFk+sKXr/ZsND2q7V9bMmXCZLjjBS+/vUhbdn6Xh856zqmVR9Ui5XmYWDl EBSneHXzzHbCQH+fC2s7uB3KPRbpBLhHJkDGNgQXvJ03UlFASH34RFeoN3Nxuna8rxbt BEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V1I4L+WuQcg7nWDY9KXq21TZu2GnKesC/k47Saxr6QE=; b=dx9fsxrAzxz9p0aRvnRdX7nH7EufpnPypIacXUNp8DjIOX/8cT/Y3Zj3KGKXv9Pm5b 55oLiL5c+bBlnCt9HfGyHlBW+B3EhML5LdTKo2DdM8BaoA1FV0+8vN9e8g9Ayvoz8dDz x8o5WYCX3mBSh2cnwGsIWcusEP498r7CsSU8o1DXM2+ojEi/b/o48rtg1UNpopxjf0Le rkuCalfM9yvtg1/jnE23JSoBMyLzOBwah+Ikp39fypV0pSccw7UG8DAI7J7LNki+R4id UvEDA4QJ3tJKrJACtsY/T5pzMoi4fT8hJOWgLHodtoVUH0KeBX5psGdgmypSMzAhuhaR TkIg== X-Gm-Message-State: AOAM531CbE1hW59wcE/YbT5EjUuIts2ydxWmEaN3irzenIRozxvXwX8w vF6eSCSaGy1FTv+HbDM5+T7bvu3SoSo= X-Google-Smtp-Source: ABdhPJwf11QWDRb1QrI5lmIND74fU73c+Xz/hXkvk9+Fcx1Ncsvp8ge/xtvcMB8fGteiXGN9oky+DQ== X-Received: by 2002:a2e:9802:: with SMTP id a2mr6017695ljj.470.1630037299403; Thu, 26 Aug 2021 21:08:19 -0700 (PDT) Received: from [192.168.2.145] (94-29-17-251.dynamic.spd-mgts.ru. [94.29.17.251]) by smtp.googlemail.com with ESMTPSA id c19sm553142ljn.75.2021.08.26.21.08.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 21:08:19 -0700 (PDT) Subject: Re: [PATCH v9 5/8] soc/tegra: pmc: Implement get_performance_state() callback To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20210827013415.24027-1-digetx@gmail.com> <20210827013415.24027-6-digetx@gmail.com> <20210827030557.aymjkky7athjxpow@vireshk-i7> <9c2287ca-4c51-d782-a0a5-4b1227c2e9db@gmail.com> <7aca6da3-89a7-a4a6-c720-8be4a105a696@gmail.com> <20210827040239.roal5jpndamzotle@vireshk-i7> From: Dmitry Osipenko Message-ID: <4a945d40-b30a-8a30-bdf8-4e17ad26cea7@gmail.com> Date: Fri, 27 Aug 2021 07:08:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210827040239.roal5jpndamzotle@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.08.2021 07:02, Viresh Kumar пишет: > On 27-08-21, 06:47, Dmitry Osipenko wrote: >> Actually, it doesn't work. >> >> The devm_tegra_core_dev_init_opp_table() needs to set clk to support older device-tree and now OPP table already has clk being set. >> >> WARNING: CPU: 2 PID: 92 at drivers/opp/core.c:2146 dev_pm_opp_set_clkname+0x97/0xb8 >> Modules linked in: >> CPU: 2 PID: 92 Comm: kworker/u8:1 Tainted: G W 5.14.0-rc7-next-20210826-00181-g6389463cbb0a #9318 >> Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) >> Workqueue: events_unbound deferred_probe_work_func >> [] (unwind_backtrace) from [] (show_stack+0x11/0x14) >> [] (show_stack) from [] (dump_stack_lvl+0x2b/0x34) >> [] (dump_stack_lvl) from [] (__warn+0xbb/0x100) >> [] (__warn) from [] (warn_slowpath_fmt+0x4b/0x80) >> [] (warn_slowpath_fmt) from [] (dev_pm_opp_set_clkname+0x97/0xb8) >> [] (dev_pm_opp_set_clkname) from [] (devm_pm_opp_set_clkname+0xf/0x64) >> [] (devm_pm_opp_set_clkname) from [] (devm_tegra_core_dev_init_opp_table+0x23/0x144) > > Why are you calling this anymore ? Older device-trees don't have OPPs, meanwhile drivers will use dev_pm_opp_set_rate() and it requires OPP table to be set up using devm_pm_opp_set_clkname(). The devm_tegra_core_dev_init_opp_table() is a common helper that sets up OPP table for Tegra drivers and it sets the clk.