From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Dmitry Safonov <dima@arista.com>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC] printk/sysrq: Don't play with console_loglevel
Date: Tue, 28 May 2019 12:21:47 +0900 [thread overview]
Message-ID: <4a9c1b20-777d-079a-33f5-ddf0a39ff788@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20190528002412.1625-1-dima@arista.com>
On 2019/05/28 9:24, Dmitry Safonov wrote:
> Provide KERN_UNSUPPRESSED printk() annotation for such legacy places.
> Make sysrq print the headers unsuppressed instead of changing
> console_loglevel.
I think that kdb also wants to use KERN_UNSUPPRESSED for making sure
that messages are printed. But that user calls dump function which is
indirectly calling printk() many times. Thus, I think that we need a
way to explicitly pass "how the message should be treated" as a
function argument.
What I suggested in my proposal ("printk: Introduce "store now but print later" prefix." at
https://lore.kernel.org/lkml/1550896930-12324-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp/T/#u )
is "whether the caller wants to defer printing to consoles regarding
this printk() call". And your suggestion is "whether the caller wants
to apply ignore_loglevel regarding this printk() call".
next prev parent reply other threads:[~2019-05-28 3:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 0:24 [RFC] printk/sysrq: Don't play with console_loglevel Dmitry Safonov
2019-05-28 3:21 ` Tetsuo Handa [this message]
2019-05-28 4:22 ` Sergey Senozhatsky
2019-05-28 8:02 ` Tetsuo Handa
2019-05-28 8:51 ` Sergey Senozhatsky
2019-05-28 10:15 ` Tetsuo Handa
2019-05-28 13:49 ` Petr Mladek
2019-06-07 17:09 ` Pavel Machek
2019-06-08 2:45 ` Tetsuo Handa
2019-06-11 15:10 ` Petr Mladek
2019-06-12 10:06 ` Tetsuo Handa
2019-05-28 4:15 ` Sergey Senozhatsky
2019-05-28 4:46 ` Sergey Senozhatsky
2019-05-28 13:42 ` Petr Mladek
2019-05-28 14:21 ` Tetsuo Handa
2019-05-28 15:03 ` Petr Mladek
2019-05-28 15:21 ` Tetsuo Handa
2019-05-28 15:58 ` Dmitry Safonov
2019-05-31 14:11 ` Tetsuo Handa
2019-06-02 6:13 ` [RFC] printk: Introduce per context console loglevel Tetsuo Handa
2019-06-06 7:59 ` Petr Mladek
2019-06-03 6:51 ` [RFC] printk/sysrq: Don't play with console_loglevel Sergey Senozhatsky
2019-06-06 7:10 ` Petr Mladek
2019-06-12 8:36 ` Sergey Senozhatsky
2019-06-12 12:00 ` Petr Mladek
2019-06-12 14:47 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a9c1b20-777d-079a-33f5-ddf0a39ff788@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).