From: Samuel Mendoza-Jonas <sam@mendozajonas.com>
To: Joel Stanley <joel@jms.id.au>, John Wang <wangzhiqiang.bj@bytedance.com>
Cc: xuxiaohan@bytedance.com, 郁雷 <yulei.sh@bytedance.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Gavin Shan" <gwshan@linux.vnet.ibm.com>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/ncsi: Use real net-device for response handler
Date: Tue, 22 Dec 2020 10:38:21 -0800 [thread overview]
Message-ID: <4a9cab3660503483fd683c89c84787a7a1b492b1.camel@mendozajonas.com> (raw)
In-Reply-To: <CACPK8XexOmUOdGmHCYVXVgA0z5m99XCAbixcgODSoUSRNCY+zA@mail.gmail.com>
On Tue, 2020-12-22 at 06:13 +0000, Joel Stanley wrote:
> On Sun, 20 Dec 2020 at 12:40, John Wang <
> wangzhiqiang.bj@bytedance.com> wrote:
> >
> > When aggregating ncsi interfaces and dedicated interfaces to bond
> > interfaces, the ncsi response handler will use the wrong net device
> > to
> > find ncsi_dev, so that the ncsi interface will not work properly.
> > Here, we use the net device registered to packet_type to fix it.
> >
> > Fixes: 138635cc27c9 ("net/ncsi: NCSI response packet handler")
> > Signed-off-by: John Wang <wangzhiqiang.bj@bytedance.com>
>
> Can you show me how to reproduce this?
>
> I don't know the ncsi or net code well enough to know if this is the
> correct fix. If you are confident it is correct then I have no
> objections.
This looks like it is probably right; pt->dev will be the original
device from ncsi_register_dev(), if a response comes in to
ncsi_rcv_rsp() associated with a different device then the driver will
fail to find the correct ncsi_dev_priv. An example of the broken case
would be good to see though.
Cheers,
Sam
>
> Cheers,
>
> Joel
>
> > ---
> > net/ncsi/ncsi-rsp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c
> > index a94bb59793f0..60ae32682904 100644
> > --- a/net/ncsi/ncsi-rsp.c
> > +++ b/net/ncsi/ncsi-rsp.c
> > @@ -1120,7 +1120,7 @@ int ncsi_rcv_rsp(struct sk_buff *skb, struct
> > net_device *dev,
> > int payload, i, ret;
> >
> > /* Find the NCSI device */
> > - nd = ncsi_find_dev(dev);
> > + nd = ncsi_find_dev(pt->dev);
> > ndp = nd ? TO_NCSI_DEV_PRIV(nd) : NULL;
> > if (!ndp)
> > return -ENODEV;
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-12-22 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 12:39 [PATCH] net/ncsi: Use real net-device for response handler John Wang
2020-12-22 6:13 ` Joel Stanley
2020-12-22 18:38 ` Samuel Mendoza-Jonas [this message]
2020-12-23 2:24 ` Jakub Kicinski
2020-12-23 5:29 ` [External] " John Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a9cab3660503483fd683c89c84787a7a1b492b1.camel@mendozajonas.com \
--to=sam@mendozajonas.com \
--cc=davem@davemloft.net \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=xuxiaohan@bytedance.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).