From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
davem@davemloft.net, gerrit@erg.abdn.ac.uk
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
dccp@vger.kernel.org
Subject: Re: [PATCH] dccp: Fix memleak in __feat_register_sp
Date: Mon, 1 Apr 2019 13:54:23 +0530 [thread overview]
Message-ID: <4ad301d4-7af2-87e4-9b52-9c4eee09b79c@codeaurora.org> (raw)
In-Reply-To: <20190401013554.17488-1-yuehaibing@huawei.com>
On 4/1/2019 7:05 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> If dccp_feat_push_change fails, we forget free the mem
> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
I don't think it is the first version. Do keep in mind to put detail here .
-Mukesh
> net/dccp/feat.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/net/dccp/feat.c b/net/dccp/feat.c
> index f227f00..db87d9f 100644
> --- a/net/dccp/feat.c
> +++ b/net/dccp/feat.c
> @@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
> if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
> return -ENOMEM;
>
> - return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
> + if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
> + kfree(fval.sp.vec);
> + return -ENOMEM;
> + }
> +
> + return 0;
> }
>
> /**
next prev parent reply other threads:[~2019-04-01 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 1:35 [PATCH] dccp: Fix memleak in __feat_register_sp Yue Haibing
2019-04-01 8:24 ` Mukesh Ojha [this message]
2019-04-01 8:44 ` YueHaibing
2019-04-02 1:16 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-03-21 14:10 Yue Haibing
2019-03-22 11:52 ` Mukesh Ojha
2019-03-22 13:39 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad301d4-7af2-87e4-9b52-9c4eee09b79c@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).