From: Rajendra Nayak <rnayak@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Ravi Kumar Bokka (Temp)" <rbokka@codeaurora.org>
Subject: Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change
Date: Mon, 26 Apr 2021 09:48:22 +0530 [thread overview]
Message-ID: <4ae40590-d806-5538-79b6-d3c343d8b7c7@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=VN+iP85D6dkEDE=C7Z9rX_-mQXU-u-Jo_5=s46tZcq0Q@mail.gmail.com>
On 4/23/2021 8:34 PM, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 23, 2021 at 12:05 AM Rajendra Nayak <rnayak@codeaurora.org> wrote:
>>
>> Fix a missed newline, and update a comment which is stale
>> after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
>> blowing on sc7280'
>> No other functional change in this patch.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> ---
>> Sending a follow-up patch for these nits since they came in after
>> the previous patch was already pulled in
>> https://lore.kernel.org/patchwork/patch/1401964/
>>
>> drivers/nvmem/qfprom.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
>> index d6d3f24..b7d2060 100644
>> --- a/drivers/nvmem/qfprom.c
>> +++ b/drivers/nvmem/qfprom.c
>> @@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = {
>> .keepout = sc7280_qfprom_keepout,
>> .nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout)
>> };
>> +
>> /**
>> * qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing.
>> * @priv: Our driver data.
>> @@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>> }
>>
>> /*
>> - * Hardware requires 1.8V min for fuse blowing; this may be
>> + * Hardware requires a min voltage for fuse blowing; this may be
>> * a rail shared do don't specify a max--regulator constraints
>> * will handle.
>> */
>
> Thanks for sending these! Is there a reason you didn't do the "else
> if" change too?
Oops, sorry, looks like i didn't scroll all the way down.
Sending a v2 shortly.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-04-26 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 7:05 [PATCH] nvmem: qfprom: minor nit fixes, no functional change Rajendra Nayak
2021-04-23 15:04 ` Doug Anderson
2021-04-26 4:18 ` Rajendra Nayak [this message]
2021-04-23 15:13 ` Joe Perches
2021-04-26 15:11 ` Doug Anderson
2021-04-27 2:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae40590-d806-5538-79b6-d3c343d8b7c7@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbokka@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).