From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>,
<jack@suse.cz>, <kernel@kolivas.org>
Subject: Re: [PATCH 1/8] block: add WRITE_BG
Date: Fri, 28 Oct 2016 08:57:07 -0600 [thread overview]
Message-ID: <4ae57faa-2f69-98cd-e276-1e091a6922b0@fb.com> (raw)
In-Reply-To: <20161027063717.GA1165@infradead.org>
On 10/27/2016 12:37 AM, Christoph Hellwig wrote:
>> * non-volatile media on completion.
>> + * WRITE_BG Background write. This is for background activity like
>> + * the periodic flush and background threshold writeback
>> *
>> */
>> #define RW_MASK REQ_OP_WRITE
>> @@ -202,6 +204,7 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset,
>> #define WRITE_FLUSH (REQ_SYNC | REQ_NOIDLE | REQ_PREFLUSH)
>> #define WRITE_FUA (REQ_SYNC | REQ_NOIDLE | REQ_FUA)
>> #define WRITE_FLUSH_FUA (REQ_SYNC | REQ_NOIDLE | REQ_PREFLUSH | REQ_FUA)
>> +#define WRITE_BG (REQ_NOIDLE | REQ_BG)
>
> I've been trying to kill off these WRITE_ flags as they aren't exactly
> helpful, see my branch here that I'm waiting for the previous serious to
> go in:
>
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-flags
I'll just adapt to whatever goes in first, not really a concern for me.
> Which also begs the question why you add the REQ_NOIDLE flag above, as
> it's only applied to synchronous queues in cfq as far as I can tell.
Right, it's a CFQ hint. We only want to potentially idle for direct/sync
writes, not buffer async writeback.
> And while I'm at nitpicking about the most trivial patch of the
> series anyway: any good reason to not just spell out the "BACKGROUND" ?
Sure, I can make that change.
--
Jens Axboe
next prev parent reply other threads:[~2016-10-28 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 20:52 [PATCHSET] block: buffered writeback throttling Jens Axboe
2016-10-26 20:52 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-10-27 6:37 ` Christoph Hellwig
2016-10-28 14:57 ` Jens Axboe [this message]
2016-10-26 20:52 ` [PATCH 2/8] writeback: add wbc_to_write_flags() Jens Axboe
2016-10-26 20:52 ` [PATCH 3/8] writeback: use WRITE_BG for kupdate and background writeback Jens Axboe
2016-10-26 20:52 ` [PATCH 4/8] writeback: track if we're sleeping on progress in balance_dirty_pages() Jens Axboe
2016-10-26 20:52 ` [PATCH 5/8] block: add code to track actual device queue depth Jens Axboe
2016-10-26 20:52 ` [PATCH 6/8] block: add scalable completion tracking of requests Jens Axboe
2016-10-26 20:52 ` [PATCH 7/8] blk-wbt: add general throttling mechanism Jens Axboe
2016-10-26 20:52 ` [PATCH 8/8] block: hook up writeback throttling Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2016-09-07 14:46 [PATCH 0/8] Throttled background buffered writeback v7 Jens Axboe
2016-09-07 14:46 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-08-31 17:05 [PATCHSET v6] Throttled background buffered writeback Jens Axboe
2016-08-31 17:05 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-09-01 7:55 ` Johannes Thumshirn
2016-09-01 7:59 ` Johannes Thumshirn
2016-04-26 15:55 [PATCHSET v5] Make background writeback great again for the first time Jens Axboe
2016-04-26 15:55 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
2016-04-18 4:24 [PATCHSET v4 0/8] Make background writeback not suck Jens Axboe
2016-04-18 4:24 ` [PATCH 1/8] block: add WRITE_BG Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae57faa-2f69-98cd-e276-1e091a6922b0@fb.com \
--to=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=kernel@kolivas.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).