From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbcD2ElY (ORCPT ); Fri, 29 Apr 2016 00:41:24 -0400 Received: from mail-db3on0125.outbound.protection.outlook.com ([157.55.234.125]:13785 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750839AbcD2ElT (ORCPT ); Fri, 29 Apr 2016 00:41:19 -0400 Authentication-Results: lysator.liu.se; dkim=none (message not signed) header.d=none;lysator.liu.se; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v7 22/24] [media] rtl2832: change the i2c gate to be mux-locked To: Wolfram Sang References: <1461165484-2314-1-git-send-email-peda@axentia.se> <1461165484-2314-23-git-send-email-peda@axentia.se> <20160428214758.GA4531@katana> CC: , Jonathan Corbet , Peter Korsgaard , Guenter Roeck , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Antti Palosaari , Mauro Carvalho Chehab , Rob Herring , Frank Rowand , Grant Likely , Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Kalle Valo , Jiri Slaby , Daniel Baluta , Lucas De Marchi , Adriana Reus , Matt Ranostay , Krzysztof Kozlowski , Hans Verkuil , Terry Heo , Arnd Bergmann , Tommi Rantala , Crestez Dan Leonard , , , , , , Peter Rosin From: Peter Rosin Message-ID: <4ae65dd6-1197-11d6-ef0a-714c0525cf3a@axentia.se> Date: Fri, 29 Apr 2016 06:41:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160428214758.GA4531@katana> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: HE1PR09CA0038.eurprd09.prod.outlook.com (10.162.19.48) To VI1PR02MB1309.eurprd02.prod.outlook.com (10.165.231.151) X-MS-Office365-Filtering-Correlation-Id: da687239-2ac5-4aea-5044-08d36fe87d6c X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1309;2:vbbBxay5I9w4v6lJGXmKpvhjiKmSmG4GuTSmGWT5KDVSi5Di7kt1o2VP7u1u3ri2s8jFnPalJus1g/17kWG8j4Ru9DcY/ASP4frNGs/4w7wleqC1F/bWG3hf2gDPwISKh22GqEw86aeST3KNEXE0AYcVBuQiSPS/X/aUSB73j51TMxJLkmULmmVYKezHwvyI;3:cjI8IALjw2GFMysKS4ClwhuE/HgULOuE1OmDJ9VOsabwfIzmarHLh5bAImKA8CUECU/pQ0irDXVvyVOSwNtaRCDsAb8VYfzimu83Fbl8ztuMU3ClfdZIRYe7d+Rj/EnV X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB1309; X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1309;25:VZQIjB2gKgFEs7baZsBD2gC30N/ijt9Q6orio4yLCbOaofQsBfXYTDuWXhcFNyjmYn5bLx0iJ2QAp7KidnxVxYGTJ9D82thiT47/oPCxJkEW93ms6b+cz1QIYeN90rLdYOKxb7fs/fApgHH7e3Jk0o1SUdjQOqrgfbOaQhI+Xly2g3cF7vSJ8yOZvrEnbB5HlRpThAAoBRtRBN0QkNONgFAE01H7YTLuT6Mpvd2jWaWhrAzRpvhIBgjdMVwl7rVzz7uZ12C0l1ukr/4M2SlYf+2WeOukkyFS4sf6SF4bs43B1yNeEAOXIgzyMBe2Y1qJpRdCvHJXFIttrL4hsd04+2Hzmq9bgRdYLrZb42Ul0b9rnFVlxpMsgt+JnV85pOZ1xiW1gDe0yeyhY7HRKKqKdmkWwNzTP7dOgId+xdGiUoTPPQzHt9CsxTvGC4GIMT63voNYT8SOtZ1tKjkjAuflNuCoCY3UtiMeEPgQz6iAtrc2XxTsfw9EZQyeJg/rqn/8rojbpdCVwBUAV1cTMLdnPSBoOrHLwUW4C1M9h4BDQUUqEbSedMTmJPzPuzVBD+zAUnSMX/PinqmELrQ+RZJCPrnmgBX0LZDns8YCbE1ue2TUvIOvkoJdUbv5DZBhcKmsmPON7jRYCxQyYDSGhrNSH23GLBDM9kyJOeNhIVq3JcPGEok5eKxc5+wE7YZki16xH5o2d5WZA4+EL1c8f3hK/reAeohFFJrSiuRD2REFJK8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR02MB1309;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB1309; X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1309;4:RxYhpC7DjYDm4LgZVIFtjxTN/rIMAecTfQDfQsxDDvrdnKqU+tiDvI8oNqlPyEEYLz2VOwU1u+/TT+pWDBv855QpoWAufODzxdHI8DM4O2tfKXyTqhxUI2DhAZ8AmEH0+lLOvVlOKzxvD0AMDGrnjjCtoP2BpnJFfFEqNG62sGUtfaZ1JNybTqom4ToUYsw3NRNaVF9GLaCSIJ/EdPSDeeTvfcN+GwDVSxbLULp51M9M96uitB0XvuIhi/mUuuBvgq+3rnW3ZC9EcIz2vL65ZzV3Z8JVmJhrb75odgTBIiMwpgGBYg310ETwYTF1LbRoBsSWhAP9Df+H8iRrKNE1GLBXVLLzEaDWojFSYCO+FVb2+yqWq8pOZxSacwC37YPlzTAw9m5qrNPUBTfUbWgpRsmqCu+feDhm7LQtvpjDGpYVr5i4a0PAMaUi7dI97W37elr2oYGyxnM2k0uCgra59Q== X-Forefront-PRVS: 0927AA37C7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6009001)(6049001)(24454002)(377424004)(66066001)(65806001)(65956001)(230700001)(4326007)(106356001)(5008740100001)(110136002)(47776003)(23746002)(92566002)(4001350100001)(64126003)(19580405001)(77096005)(19580395003)(31696002)(15975445007)(81166005)(1096002)(2950100001)(83506001)(586003)(50986999)(6116002)(76176999)(2906002)(50466002)(189998001)(3846002)(42186005)(86362001)(117156001)(36756003)(31686004)(54356999)(5004730100002)(33646002)(74482002)(65826006)(7059030)(42262002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR02MB1309;H:[192.168.0.125];FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;VI1PR02MB1309;23:nO6S9SNWeHnSgjWyhg9YKBw28fy+YzvQyCxPs?= =?Windows-1252?Q?wGgCywilAlqFMBTm2i7YaqlI2QLE+qcw190tY1CiRHa981601B36AVYr?= =?Windows-1252?Q?8ZCjoNsDw83Wo5KKkQR2TADvX9ezxPGFePZnz520sXOLmc47pMvKvfH1?= =?Windows-1252?Q?8C4oqhvV9kMmxWXac/vEs9AdC7Kmk6Aap2phGgW5vGWYXXjJZmkRhDet?= =?Windows-1252?Q?5/tNegkFJWCAkntrAVBAGjPOq5zRw8wZ6e3c1b1KGnFY8agek+4b5APk?= =?Windows-1252?Q?oHAQoLlUchuUlJajCyFUOipcDMSiDAKFWE52karJeN/g5vzhxg0mu1X8?= =?Windows-1252?Q?9lhtW9SktxD7tH/cxavnP3s0FCfVN0Lt/pvFs7iUCF1lrWQl3v3k63ne?= =?Windows-1252?Q?nltkLb1p2jcV7FVZhmWABXM2ruIjkU11CZ+Azc1a9xXhxIo0651fZSlD?= =?Windows-1252?Q?oRHSPubzdclDJjPwEtRyECgBsHTs8CPYtZGgVu3kRuPqMSU/NyddfFph?= =?Windows-1252?Q?EQTkNpX6jVD7dPcnhopkdp5mV/7fC4OQ/riGb01bwi/esGKrsHWIIc1u?= =?Windows-1252?Q?oqqOPwa12O5VX6tByYZFwFpWCZ6JTwDiea28Uw0wuMRxlrUxayPATwSK?= =?Windows-1252?Q?QZVf5/OX2XIWNkAzRe8DQ+754WIkOyb5pIiVpJ1jz8YQ83oCY7/rVv14?= =?Windows-1252?Q?3DT2fRpNWMpKl85FzM4svNXQC/IhjdA5pMTl36p9o1j26jJJ6MlQRA1r?= =?Windows-1252?Q?Pr/9CYYFXdCPeZD3LGDreSU5CngB5qlx/nkMxPBbL1Ts58XnzOjpah6z?= =?Windows-1252?Q?gbitSVA8pQPk4xyjxj9UrPMQVUM96E87ami2G4Yw4+mbjcDX9f5n4PYz?= =?Windows-1252?Q?r+XK5u92u5jn3fXpZMqi/hE0qJZddld5I5qnpnlAlUqdkmZwnuRR0cT7?= =?Windows-1252?Q?gAx06Rt7BIk4/OP5yJXPJD8PVIZ3JR54zpiW4HQn1s/Z6nWdRtBgHrmV?= =?Windows-1252?Q?EDhdUa5ZbDX1fEbKTlDPtgGyFYU8hDohdopV9bC6csCPblpIQ4CY79ZL?= =?Windows-1252?Q?4UwaaT/gVN6JdQOX5cHLrH6YTq54e2RafZke9quZjHf+YB5Rus0OzBbX?= =?Windows-1252?Q?hv2fCtvk7nV2aiqM28Xrf1EKvsD2ZpmnQBMnUjxiDUkI5qaHFi7a0V8V?= =?Windows-1252?Q?dNdQLW1cxFP0ZzL7LYDGL1O1y3x5CRymxUofEWK446vxsBzcQgsRW3fM?= =?Windows-1252?Q?8HIqj/qDrn8B5mcEr2KcXwGDtjeFUhuGxd5TammRtXklmibKjwxI782J?= =?Windows-1252?Q?sabpkP6LqssW14ydjNTGI8xaE9NcradRLAeNVyJz/DwQ0btlL8BNqa9O?= =?Windows-1252?Q?WAlmPNOiztfSmxa34Z3HBr2i77FkhG5lxN/NqbX65HqJGzSBCkIWEM?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR02MB1309;5:FsfASpxZUhOlnRS3d3FOyGqngeG7nwA0+1TW/uFjzPtD8jt0wRwQ5b1lyn35f2JpXsBXo5ZDj1/SMDIlkXLfq9es6gSOUAB/cH052gEXnpEmZ6FTjQKbEYl3PobGTd02BdK3VjH9h83HYQ4Sre5KDQ==;24:n/+pRUvLw7+3aiIskISxgv/P9+CQjsjUIXKLxvjiRaUefQgmpPKL2awUtVG97cJ9r6eth2u07kvjK+dWrtJFwYw2IS68/PVJ8EUYuBb7jI8=;7:orlA7xFp4VL9Kxvm+unzkz6OffADyBDHXf9LLXeblaX+DJiRhXynT5Thjsh8Wn+b6ULgsFJ7gDXYLVCzgCkluRDCftxPRUtcYfw8xTM8STJEqDQnbLtnDGeDkAjE/71AdW/W/jiT1qa0b50Sk7Gkin8JbV7oLgti4c3SidviHMDFhPFRsazyPMeoHEEJxtEt SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2016 04:41:07.8904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB1309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-04-28 23:47, Wolfram Sang wrote: > On Wed, Apr 20, 2016 at 05:18:02PM +0200, Peter Rosin wrote: >> The root i2c adapter lock is then no longer held by the i2c mux during >> accesses behind the i2c gate, and such accesses need to take that lock >> just like any other ordinary i2c accesses do. >> >> So, declare the i2c gate mux-locked, and zap the regmap overrides >> that makes the i2c accesses unlocked and use plain old regmap >> accesses. This also removes the need for the regmap wrappers used by >> rtl2832_sdr, so deconvolute the code further and provide the regmap >> handle directly instead of the wrapper functions. >> >> Signed-off-by: Peter Rosin > Antti, I'd need some tag from you since this is not the i2c realm. > Antti sent this: https://lkml.org/lkml/2016/4/20/828 and I added a Tested-by in v8 https://github.com/peda-r/i2c-mux/commit/c023584d34db7aacbc59f28386378131cfa970d2 but the patch was never sent as an email, only as part of a pull request for https://github.com/peda-r/i2c-mux/commits/mux-core-and-locking-8 So, I think all is ok, or do you need more than Tested-by? Cheers, Peter