From: Shuah Khan <skhan@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Gow <davidgow@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Petr Mladek <pmladek@suse.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kunit: tool: Force the use of the 'tty' console for UML
Date: Mon, 4 Jan 2021 09:23:57 -0700 [thread overview]
Message-ID: <4ae7779c-15c5-0474-5840-44531dcf1d94@linuxfoundation.org> (raw)
In-Reply-To: <20201222111102.GC4077@smile.fi.intel.com>
On 12/22/20 4:11 AM, Andy Shevchenko wrote:
> On Mon, Dec 21, 2020 at 11:39:00PM -0800, David Gow wrote:
>> kunit_tool relies on the UML console outputting printk() output to the
>> tty in order to get results. Since the default console driver could
>> change, pass 'console=tty' to the kernel.
>>
>> This is triggered by a change[1] to use ttynull as a fallback console
>> driver which -- by chance or by design -- seems to have changed the
>> default console output on UML, breaking kunit_tool. While this may be
>> fixed, we should be less fragile to such changes in the default.
>>
>> [1]:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=757055ae8dedf5333af17b3b5b4b70ba9bc9da4e
>
> Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
Thank you all. Now in linux-kselftest kunit-fixes branch.
Will send this up for rc3.
Sorry for the delay - have been away from the keyboard for a
bit.
thanks,
-- Shuah
next prev parent reply other threads:[~2021-01-04 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 7:39 [PATCH] kunit: tool: Force the use of the 'tty' console for UML David Gow
2020-12-22 11:11 ` Andy Shevchenko
2021-01-04 16:23 ` Shuah Khan [this message]
2021-01-05 16:21 ` Petr Mladek
2021-01-05 16:34 ` Shuah Khan
2021-01-05 18:57 ` Andy Shevchenko
2021-01-05 19:52 ` Shuah Khan
2021-01-06 4:29 ` David Gow
2021-01-07 16:53 ` Petr Mladek
2021-01-07 18:13 ` Shuah Khan
2020-12-27 20:00 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae7779c-15c5-0474-5840-44531dcf1d94@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).