From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E81FC65C22 for ; Fri, 2 Nov 2018 12:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3FCA2081B for ; Fri, 2 Nov 2018 12:50:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3FCA2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbeKBV5u (ORCPT ); Fri, 2 Nov 2018 17:57:50 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:58666 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbeKBV5u (ORCPT ); Fri, 2 Nov 2018 17:57:50 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id wA2Cnd4x067264; Fri, 2 Nov 2018 07:49:39 -0500 Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wA2CndBR081574 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 Nov 2018 07:49:39 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 2 Nov 2018 07:49:37 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 2 Nov 2018 07:49:36 -0500 Received: from [192.168.2.10] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id wA2CnTZY002750; Fri, 2 Nov 2018 07:49:30 -0500 Subject: Re: [PATCH v3 6/7] clk: clk-twl6040: Free of_provider at remove To: Matti Vaittinen , Jonathan Corbet , Michael Turquette , Stephen Boyd , Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Russell King , Andy Gross , David Brown , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Andrey Smirnov , Sebastian Reichel , Guenter Roeck , Rob Herring , Huang Shijie , Akshu Agrawal , "Rafael J. Wysocki" , Daniel Kurtz , CC: , , , , , , References: <855d60c35f092de196b131838fe0b07e9d3080d3.1541161503.git.matti.vaittinen@fi.rohmeurope.com> From: Peter Ujfalusi Message-ID: <4b0cceec-ddc8-5398-33a1-e0e91dabdcdf@ti.com> Date: Fri, 2 Nov 2018 14:49:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <855d60c35f092de196b131838fe0b07e9d3080d3.1541161503.git.matti.vaittinen@fi.rohmeurope.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/18 2:37 PM, Matti Vaittinen wrote: > use devm variant for of_provider registration so provider is freed > at exit. Acked-by: Peter Ujfalusi > > Signed-off-by: Matti Vaittinen > --- > drivers/clk/clk-twl6040.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/clk-twl6040.c b/drivers/clk/clk-twl6040.c > index 25dfe050ae9f..e9da09453eb2 100644 > --- a/drivers/clk/clk-twl6040.c > +++ b/drivers/clk/clk-twl6040.c > @@ -108,9 +108,8 @@ static int twl6040_pdmclk_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, clkdata); > > - return of_clk_add_hw_provider(pdev->dev.parent->of_node, > - of_clk_hw_simple_get, > - &clkdata->pdmclk_hw); > + return devm_of_clk_add_parent_hw_provider(&pdev->dev, > + of_clk_hw_simple_get, &clkdata->pdmclk_hw); > } > > static struct platform_driver twl6040_pdmclk_driver = { > - Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki