From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Michel Dänzer" <michel@daenzer.net>,
zhaoxiao <zhaoxiao@uniontech.com>,
airlied@linux.ie
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
David1.Zhou@amd.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: radeon: r600_dma: Replace cpu_to_le32() by lower_32_bits()
Date: Mon, 16 Aug 2021 14:47:18 +0200 [thread overview]
Message-ID: <4b1faa87-a4d8-57e2-80d0-817c5df8f643@gmail.com> (raw)
In-Reply-To: <54590a79-7047-cd6f-0f54-a005bdc69769@daenzer.net>
Am 13.08.21 um 17:03 schrieb Michel Dänzer:
> On 2021-08-13 10:54 a.m., zhaoxiao wrote:
>> This patch fixes the following sparse errors:
>> drivers/gpu/drm/radeon/r600_dma.c:247:30: warning: incorrect type in assignment (different base types)
>> drivers/gpu/drm/radeon/r600_dma.c:247:30: expected unsigned int volatile [usertype]
>> drivers/gpu/drm/radeon/r600_dma.c:247:30: got restricted __le32 [usertype]
>>
>> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
>> ---
>> drivers/gpu/drm/radeon/r600_dma.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/r600_dma.c b/drivers/gpu/drm/radeon/r600_dma.c
>> index fb65e6fb5c4f..a2d0b1edcd22 100644
>> --- a/drivers/gpu/drm/radeon/r600_dma.c
>> +++ b/drivers/gpu/drm/radeon/r600_dma.c
>> @@ -244,7 +244,7 @@ int r600_dma_ring_test(struct radeon_device *rdev,
>> gpu_addr = rdev->wb.gpu_addr + index;
>>
>> tmp = 0xCAFEDEAD;
>> - rdev->wb.wb[index/4] = cpu_to_le32(tmp);
>> + rdev->wb.wb[index/4] = lower_32_bits(tmp);
>>
>> r = radeon_ring_lock(rdev, ring, 4);
>> if (r) {
>>
> Seems better to mark rdev->wb.wb as little endian instead. It's read with le32_to_cpu (with some exceptions which look like bugs), which would result in 0xADEDFECA like this.
Yeah, that patch doesn't look correct at all and most likely breaks ring
test on big endian systems.
Christian.
prev parent reply other threads:[~2021-08-16 12:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 8:54 [PATCH] drm: radeon: r600_dma: Replace cpu_to_le32() by lower_32_bits() zhaoxiao
2021-08-13 15:03 ` Michel Dänzer
2021-08-16 12:47 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1faa87-a4d8-57e2-80d0-817c5df8f643@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=zhaoxiao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).