From: Guenter Roeck <linux@roeck-us.net>
To: Jason Wang <jasowang@redhat.com>, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Anders Roxell <anders.roxell@linaro.org>
Subject: Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
Date: Fri, 19 Feb 2021 07:38:27 -0800 [thread overview]
Message-ID: <4b2378d8-0061-c6ed-f377-492649869581@roeck-us.net> (raw)
In-Reply-To: <20210219084509.48269-1-jasowang@redhat.com>
On 2/19/21 12:45 AM, Jason Wang wrote:
> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> lot of confusion. E.g it may break various default configs which want
> virtio devices.
>
> So this patch fixes this by hide the prompot and document the
... by hiding the prompt and documenting ...
> dependency.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Anders Roxell <anders.roxell@linaro.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/virtio/Kconfig | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 6b9b81f4b8c2..be7df369bc2b 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> VIRTIO_F_ACCESS_PLATFORM
>
> config VIRTIO_PCI_MODERN
> - tristate "Modern Virtio PCI Device"
> - depends on PCI
> + tristate
> help
> Modern PCI device implementation. This module implements the
> basic probe and control for devices which are based on modern
> - PCI device with possible vendor specific extensions.
> + PCI device with possible vendor specific extensions. Any
> + module that selects this module must depend on PCI.
>
> menuconfig VIRTIO_MENU
> bool "Virtio drivers"
> @@ -28,7 +28,8 @@ if VIRTIO_MENU
>
> config VIRTIO_PCI
> tristate "PCI driver for virtio devices"
> - depends on VIRTIO_PCI_MODERN
> + depends on PCI
> + select VIRTIO_PCI_MODERN
> select VIRTIO
> help
> This driver provides support for virtio based paravirtual device
>
next prev parent reply other threads:[~2021-02-19 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 8:45 [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
2021-02-19 10:12 ` Arnd Bergmann
2021-02-22 3:41 ` Jason Wang
2021-02-19 10:13 ` Christoph Hellwig
2021-02-20 1:51 ` Jason Wang
2021-02-19 15:38 ` Guenter Roeck [this message]
2021-02-22 3:42 ` Jason Wang
2021-02-22 7:29 ` Michael S. Tsirkin
2021-02-22 9:06 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b2378d8-0061-c6ed-f377-492649869581@roeck-us.net \
--to=linux@roeck-us.net \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).