From: Jiri Slaby <jslaby@suse.cz>
To: lirongqing@baidu.com, robh@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: not call tty close in fallback
Date: Mon, 14 Jan 2019 08:51:19 +0100 [thread overview]
Message-ID: <4b6e790b-ea6a-f715-6290-4d026921b632@suse.cz> (raw)
In-Reply-To: <1547448961-9588-1-git-send-email-yes>
yes@hpe.com:
550 5.1.1 User Unknown
You are sending e-mails/patches from a non-existant address?
On 14. 01. 19, 7:56, yes@hpe.com wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> when fail to open tty, tty is not in open status and not need
> to call close
But tty drivers are special and expect close even on failed open, right?
See tty_open.
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/tty/serdev/serdev-ttyport.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c
> index fa1672993b4c..bcc1e27d00de 100644
> --- a/drivers/tty/serdev/serdev-ttyport.c
> +++ b/drivers/tty/serdev/serdev-ttyport.c
> @@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl)
>
> ret = tty->ops->open(serport->tty, NULL);
> if (ret)
> - goto err_close;
> + goto err_unlock;
>
> tty_unlock(serport->tty);
>
> @@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl)
>
> return 0;
>
> -err_close:
> - tty->ops->close(tty, NULL);
> err_unlock:
> tty_unlock(tty);
> tty_release_struct(tty, serport->tty_idx);
>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2019-01-14 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1547448961-9588-1-git-send-email-yes>
2019-01-14 7:20 ` [PATCH] tty: not call tty close in fallback Jiri Slaby
2019-01-14 7:51 ` Jiri Slaby [this message]
[not found] <5c3c3289.1c69fb81.c1953.0900SMTPIN_ADDED_BROKEN@mx.google.com>
2019-02-19 12:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b6e790b-ea6a-f715-6290-4d026921b632@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).