From: Leonard Crestez <leonard.crestez@nxp.com>
To: "mperttunen@nvidia.com" <mperttunen@nvidia.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cyndis@kapsi.fi" <cyndis@kapsi.fi>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] clk: core: Potentially free connection id
Date: Wed, 11 Jul 2018 10:17:10 +0000 [thread overview]
Message-ID: <4b809427e9b922ba41efafb20a97e0698e9cd3d0.camel@nxp.com> (raw)
In-Reply-To: <20180711082104.27955-1-mperttunen@nvidia.com>
On Wed, 2018-07-11 at 11:21 +0300, Mikko Perttunen wrote:
> Patch "clk: core: Copy connection id" made it so that the connector
> id (con_id) is kstrdup_const'ed to cater to drivers that pass non-
> constant connection ids. The patch added the corresponding
> kfree_const
> to __clk_free_clk, but struct clk's can be freed also via __clk_put.
> Add the kfree_const call to __clk_put and add comments to both
> functions to remind that the logic in them should be kept in sync.
>
> Fixes: 253160a8ad06 ("clk: core: Copy connection id")
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Yes, sorry I missed this.
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Maybe a static __clk_free_mem function could be created instead of
comments asking to keep things in sync? But there are only 2 lines so
it's fine.
next prev parent reply other threads:[~2018-07-11 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 8:21 [PATCH] clk: core: Potentially free connection id Mikko Perttunen
2018-07-11 10:17 ` Leonard Crestez [this message]
2018-07-25 16:30 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b809427e9b922ba41efafb20a97e0698e9cd3d0.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=cyndis@kapsi.fi \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).