From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: axboe@kernel.dk, vkoul@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel()
Date: Mon, 13 Jan 2020 12:22:51 +0100 [thread overview]
Message-ID: <4b9f3d2b-e1e4-48a4-c0e2-624bac77dba9@samsung.com> (raw)
In-Reply-To: <20191217074033.21831-1-peter.ujfalusi@ti.com>
On 12/17/19 8:40 AM, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/pata_pxa.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
> index 41430f79663c..71678bed04b0 100644
> --- a/drivers/ata/pata_pxa.c
> +++ b/drivers/ata/pata_pxa.c
> @@ -274,10 +274,9 @@ static int pxa_ata_probe(struct platform_device *pdev)
> /*
> * Request the DMA channel
> */
> - data->dma_chan =
> - dma_request_slave_channel(&pdev->dev, "data");
> - if (!data->dma_chan)
> - return -EBUSY;
> + data->dma_chan = dma_request_chan(&pdev->dev, "data");
> + if (IS_ERR(data->dma_chan))
> + return PTR_ERR(data->dma_chan);
> ret = dmaengine_slave_config(data->dma_chan, &config);
> if (ret < 0) {
> dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
>
prev parent reply other threads:[~2020-01-13 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191217074028eucas1p1eeef714e4d8c2cff2c133ffd239d7468@eucas1p1.samsung.com>
2019-12-17 7:40 ` [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-13 11:22 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b9f3d2b-e1e4-48a4-c0e2-624bac77dba9@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).