From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE29FC432C3 for ; Thu, 21 Nov 2019 19:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A697620672 for ; Thu, 21 Nov 2019 19:00:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="v+yf4A6a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726762AbfKUTAH (ORCPT ); Thu, 21 Nov 2019 14:00:07 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:36792 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfKUTAH (ORCPT ); Thu, 21 Nov 2019 14:00:07 -0500 Received: by mail-io1-f67.google.com with SMTP id s3so4767779ioe.3 for ; Thu, 21 Nov 2019 11:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SnPj/n1gyGH0v59Wr7JbdghJQmtp3nHLjHxqakaNQHY=; b=v+yf4A6aRgckwfN25zrv7pKeKGK6P2XVAvXldacF+NRZh72s3fqXxw895IGgT3kpJ8 J0OgyZgRa5EykvqtQ4nlYu2dzwJqrcPu3ygwQatG0jYJ4izFKF4YiFuO3M8eE3TAZMUa JaiLbU169r/mOsVmJIvi2s+I58CDBQY4tdMucTV3RV4eLage8BB3Yd75kYYyAi9ndu0n F4ePjwNjCbZ7yFLNqVUK78A2YqBBp0Wtv6MMpPS5g1y0FUCv0/EXWLB4B/dY/CSpTxFg mrO6v7iaLGZcq2pVfRo/btCriOBV1ZR8IcYvUwaaZttwkJlvUftuWYKJ9wpvxJI32QwW rAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SnPj/n1gyGH0v59Wr7JbdghJQmtp3nHLjHxqakaNQHY=; b=Gm//S/vP/IipI/FdsFPwHrzBRLVMyjC1Lyx6bv/ZfW9z2Urgti0eHfi8EhcajfHfsP RmQaOXjN5B0OtQ/ynHaOAkRk6moEhUM7Aof1UAYidebmMVKStwe5qrJpWSMdPFhBCi3b g4IT8z7lK/9aKRor6BH2DnkYxmt4HsgVHIaGPPjFY5Db1Nj7K17kFPF0/jZzkDfdGrpU d2xgvCpmnrBeqivO7Nmk6Cdyq4BX0e14xgwDnNEWC9LQvoc+5nojxxwlJtAa0NoleHQY WrdxyBe8/eNqre03Dfspyqo4kqS9cAj9UBWeFEKlSiPYZWdWyIFxq3xj+Gz9DJwclFgJ 1jMQ== X-Gm-Message-State: APjAAAVQeQ+nOBrihpdM1/ED4UIJkHri+9WCDstL3l+KFB2uspuz4+54 /ad7Tnh0xpdl+gKkd3fspK5z+L2SXUnAoriN X-Google-Smtp-Source: APXvYqwRT3wSZZTVGt8hSDmQAxZRovFkX++EpdpjERq09vW/IKK+mqwWvCHPHk9lkKVR7nOrptsX6g== X-Received: by 2002:a02:b00c:: with SMTP id p12mr4583129jah.112.1574362806304; Thu, 21 Nov 2019 11:00:06 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id i79sm1492127ild.6.2019.11.21.11.00.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 11:00:05 -0800 (PST) Subject: Re: [PATCH v4 00/10] Fix cdrom autoclose To: Michal Suchanek , linux-scsi@vger.kernel.org, linux-block@vger.kernel.org Cc: Jonathan Corbet , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Eric Biggers , "J. Bruce Fields" , Mauro Carvalho Chehab , Benjamin Coddington , Ming Lei , Chaitanya Kulkarni , Bart Van Assche , Damien Le Moal , Hou Tao , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jan Kara , Hannes Reinecke , "Ewan D. Milne" , Christoph Hellwig , Matthew Wilcox References: From: Jens Axboe Message-ID: <4ba670de-80d4-130e-91f3-c6e1cc9c7a47@kernel.dk> Date: Thu, 21 Nov 2019 12:00:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/19 10:13 AM, Michal Suchanek wrote: > Hello, > > there is cdrom autoclose feature that is supposed to close the tray, > wait for the disc to become ready, and then open the device. > > This used to work in ancient times. Then in old times there was a hack > in util-linux which worked around the breakage which probably resulted > from switching to scsi emulation. > > Currently util-linux maintainer refuses to merge another hack on the > basis that kernel still has the feature so it should be fixed there. > The code needs not be replicated in every userspace utility like mount > or dd which has no business knowing which devices are CD-roms and where > the autoclose setting is in the kernel. This is a lot of code/churn (and even an fops addition...) to work around a broken hw emulation, essentially. Why aren't we just pushing vmware to fix this? -- Jens Axboe