From: Matt Redfearn <matt.redfearn@mips.com>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: <antonynpavlov@gmail.com>, <jhogan@kernel.org>,
<ralf@linux-mips.org>, <linux-mips@linux-mips.org>,
<geert@linux-m68k.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c
Date: Tue, 3 Apr 2018 14:51:06 +0100 [thread overview]
Message-ID: <4ba976ed-7294-18ec-187f-7105a9782283@mips.com> (raw)
In-Reply-To: <mhng-e7e3dffe-bc80-4bea-8cf5-4d8afb76565a@palmer-si-x1c4>
Hi Palmer,
On 29/03/18 22:59, Palmer Dabbelt wrote:
> On Thu, 29 Mar 2018 03:41:21 PDT (-0700), matt.redfearn@mips.com wrote:
>> From: Palmer Dabbelt <palmer@sifive.com>
>>
>> As part of the MIPS conversion to use the generic GCC library routines,
>> Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2(). This
>> patch rectifies the problem.
>>
>> CC: Matt Redfearn <matt.redfearn@mips.com>
>> CC: Antony Pavlov <antonynpavlov@gmail.com>
>> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
>> Reviewed-by: Matt Redfearn <matt.redfearn@mips.com>
>> Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2:
>> add notrace to lib/ucmpdi2.c
>>
>> lib/ucmpdi2.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
>> index 25ca2d4c1e19..597998169a96 100644
>> --- a/lib/ucmpdi2.c
>> +++ b/lib/ucmpdi2.c
>> @@ -17,7 +17,7 @@
>> #include <linux/module.h>
>> #include <linux/libgcc.h>
>>
>> -word_type __ucmpdi2(unsigned long long a, unsigned long long b)
>> +word_type notrace __ucmpdi2(unsigned long long a, unsigned long long b)
>> {
>> const DWunion au = {.ll = a};
>> const DWunion bu = {.ll = b};
>
> Ah, thanks, I think I must have forgotten about this. I assume these
> three are going through your tree?
Yeah I think that's the plan - James will need your ack to patch 2 if
that's ok.
Thanks,
Matt
next prev parent reply other threads:[~2018-04-03 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 10:41 [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c Matt Redfearn
2018-03-29 10:41 ` [PATCH v4 2/3] lib: Rename compiler intrinsic selects to GENERIC_LIB_* Matt Redfearn
2018-03-29 10:41 ` [PATCH v4 3/3] MIPS: use generic GCC library routines from lib/ Matt Redfearn
2018-04-03 8:53 ` James Hogan
2018-04-03 9:23 ` Matt Redfearn
2018-03-29 21:59 ` [PATCH v4 1/3] Add notrace to lib/ucmpdi2.c Palmer Dabbelt
2018-04-03 13:51 ` Matt Redfearn [this message]
2018-04-03 14:45 ` James Hogan
2018-04-03 22:45 ` Palmer Dabbelt
2018-04-03 22:40 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba976ed-7294-18ec-187f-7105a9782283@mips.com \
--to=matt.redfearn@mips.com \
--cc=antonynpavlov@gmail.com \
--cc=geert@linux-m68k.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=palmer@sifive.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).