From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASN.1: mark expected switch fall-throughs
Date: Fri, 25 Jan 2019 18:57:54 -0600 [thread overview]
Message-ID: <4bb2f0bd-f93c-f8f6-5a72-a0c5035fb8de@embeddedor.com> (raw)
In-Reply-To: <CAGXu5jJXsLw7N-M9Ev_BMapC3L2Q1t_qn0rbJEjwOQY1=us76w@mail.gmail.com>
On 1/25/19 6:38 PM, Kees Cook wrote:
> On Sat, Jan 26, 2019 at 9:49 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
Now applied to for-next/kspp, thanks.
https://git.kernel.org/gustavoars/c/482c7212e6af6a3362e337fb49e2e101e4578644
Cheers!
--
Gustavo
prev parent reply other threads:[~2019-01-26 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 20:48 [PATCH] ASN.1: mark expected switch fall-throughs Gustavo A. R. Silva
2019-01-26 0:38 ` Kees Cook
2019-01-26 0:57 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bb2f0bd-f93c-f8f6-5a72-a0c5035fb8de@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).