linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: isaku.yamahata@intel.com
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>,
	erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>,
	David Matlack <dmatlack@google.com>,
	Kai Huang <kai.huang@intel.com>,
	Zhi Wang <zhi.wang.linux@gmail.com>
Subject: [PATCH v12 034/106] KVM: x86/mmu: Require TDP MMU and mmio caching for TDX
Date: Mon, 27 Feb 2023 00:22:33 -0800	[thread overview]
Message-ID: <4bb83ed60289137bcc2ca72c56a88c2f935536af.1677484918.git.isaku.yamahata@intel.com> (raw)
In-Reply-To: <cover.1677484918.git.isaku.yamahata@intel.com>

From: Isaku Yamahata <isaku.yamahata@intel.com>

As TDP MMU is becoming main stream than the legacy MMU, the legacy MMU
support for TDX isn't implemented.  TDX requires KVM mmio caching.  Disable
TDX support when TDP MMU or mmio caching aren't supported.

Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
---
 arch/x86/kvm/mmu/mmu.c  | 1 +
 arch/x86/kvm/vmx/main.c | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index 898f36f2d84a..a6b0b53634e8 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -99,6 +99,7 @@ module_param_named(flush_on_reuse, force_flush_and_sync_on_reuse, bool, 0644);
  * If the hardware supports that we don't need to do shadow paging.
  */
 bool tdp_enabled = false;
+EXPORT_SYMBOL_GPL(tdp_enabled);
 
 bool __ro_after_init tdp_mmu_allowed;
 
diff --git a/arch/x86/kvm/vmx/main.c b/arch/x86/kvm/vmx/main.c
index fa0590e37ec1..0cd85c96ed84 100644
--- a/arch/x86/kvm/vmx/main.c
+++ b/arch/x86/kvm/vmx/main.c
@@ -2,6 +2,7 @@
 #include <linux/moduleparam.h>
 
 #include "x86_ops.h"
+#include "mmu.h"
 #include "vmx.h"
 #include "nested.h"
 #include "pmu.h"
@@ -38,6 +39,11 @@ static __init int vt_hardware_setup(void)
 
 	enable_tdx = enable_tdx && !tdx_hardware_setup(&vt_x86_ops);
 
+	/* TDX requires KVM TDP MMU and MMIO caching. */
+	if (enable_tdx && (!tdp_enabled || !enable_mmio_caching)) {
+		enable_tdx = false;
+		pr_warn_ratelimited("tdp mmu and mmio caching need to be enabled.\n");
+	}
 	return 0;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2023-02-27  8:26 UTC|newest]

Thread overview: 120+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27  8:21 [PATCH v12 000/106] KVM TDX basic feature support isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 001/106] [MARKER] The start of TDX KVM patch series: TDX architectural definitions isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 002/106] KVM: TDX: Define " isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 003/106] KVM: TDX: Add TDX "architectural" error codes isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 004/106] KVM: TDX: Add C wrapper functions for SEAMCALLs to the TDX module isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 005/106] KVM: TDX: Add helper functions to print TDX SEAMCALL error isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 006/106] [MARKER] The start of TDX KVM patch series: TD VM creation/destruction isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 007/106] x86/cpu: Add helper functions to allocate/free TDX private host key id isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 008/106] x86/virt/tdx: Add a helper function to return system wide info about TDX module isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 009/106] KVM: TDX: x86: Add ioctl to get TDX systemwide parameters isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 010/106] KVM: TDX: Add place holder for TDX VM specific mem_enc_op ioctl isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 011/106] KVM: x86, tdx: Make KVM_CAP_MAX_VCPUS backend specific isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 012/106] KVM: x86/vmx, tdx: Allow VMX, TDX to override KVM_ENABLE_CAP isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 013/106] KVM: TDX: create/destroy VM structure isaku.yamahata
2023-03-01  7:24   ` Chenyi Qiang
2023-03-02  1:11     ` Isaku Yamahata
2023-02-27  8:22 ` [PATCH v12 014/106] KVM: TDX: initialize VM with TDX specific parameters isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 015/106] KVM: TDX: Make pmu_intel.c ignore guest TD case isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 016/106] KVM: TDX: Refuse to unplug the last cpu on the package isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 017/106] [MARKER] The start of TDX KVM patch series: TD vcpu creation/destruction isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 018/106] KVM: TDX: allocate/free TDX vcpu structure isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 019/106] KVM: TDX: Do TDX specific vcpu initialization isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 020/106] [MARKER] The start of TDX KVM patch series: KVM MMU GPA shared bits isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 021/106] KVM: x86/mmu: introduce config for PRIVATE KVM MMU isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 022/106] KVM: x86/mmu: Add address conversion functions for TDX shared bit of GPA isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 023/106] [MARKER] The start of TDX KVM patch series: KVM TDP refactoring for TDX isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 024/106] KVM: Allow page-sized MMU caches to be initialized with custom 64-bit values isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 025/106] KVM: x86/mmu: Replace hardcoded value 0 for the initial value for SPTE isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 026/106] KVM: x86/mmu: Allow non-zero value for non-present SPTE and removed SPTE isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 027/106] KVM: x86/mmu: Add Suppress VE bit to shadow_mmio_mask/shadow_present_mask isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 028/106] KVM: x86/mmu: Track shadow MMIO value on a per-VM basis isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 029/106] KVM: x86/mmu: Disallow fast page fault on private GPA isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 030/106] KVM: x86/mmu: Allow per-VM override of the TDP max page level isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 031/106] KVM: VMX: Introduce test mode related to EPT violation VE isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 032/106] [MARKER] The start of TDX KVM patch series: KVM TDP MMU hooks isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 033/106] KVM: x86/tdp_mmu: Init role member of struct kvm_mmu_page at allocation isaku.yamahata
2023-02-27  8:22 ` isaku.yamahata [this message]
2023-02-27  8:22 ` [PATCH v12 035/106] KVM: x86/mmu: Add a new is_private member for union kvm_mmu_page_role isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 036/106] KVM: x86/mmu: Add a private pointer to struct kvm_mmu_page isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 037/106] KVM: Add flags to struct kvm_gfn_range isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 038/106] KVM: x86/tdp_mmu: Don't zap private pages for unsupported cases isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 039/106] KVM: x86/tdp_mmu: Sprinkle __must_check isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 040/106] KVM: x86/tdp_mmu: Support TDX private mapping for TDP MMU isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 041/106] [MARKER] The start of TDX KVM patch series: TDX EPT violation isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 042/106] KVM: x86/mmu: Disallow dirty logging for x86 TDX isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 043/106] KVM: x86/mmu: TDX: Do not enable page track for TD guest isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 044/106] KVM: VMX: Split out guts of EPT violation to common/exposed function isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 045/106] KVM: VMX: Move setting of EPT MMU masks to common VT-x code isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 046/106] KVM: TDX: Add accessors VMX VMCS helpers isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 047/106] KVM: TDX: Add load_mmu_pgd method for TDX isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 048/106] KVM: TDX: Retry seamcall when TDX_OPERAND_BUSY with operand SEPT isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 049/106] KVM: TDX: TDP MMU TDX support isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 050/106] KVM: TDX: MTRR: implement get_mt_mask() for TDX isaku.yamahata
2023-03-09  9:03   ` Chenyi Qiang
2023-03-10 21:18     ` Isaku Yamahata
2023-02-27  8:22 ` [PATCH v12 051/106] [MARKER] The start of TDX KVM patch series: TD finalization isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 052/106] KVM: x86/mmu: Introduce kvm_mmu_map_tdp_page() for use by TDX isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 053/106] KVM: TDX: Create initial guest memory isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 054/106] KVM: TDX: Finalize VM initialization isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 055/106] [MARKER] The start of TDX KVM patch series: TD vcpu enter/exit isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 056/106] KVM: TDX: Add helper assembly function to TDX vcpu isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 057/106] KVM: TDX: Implement TDX vcpu enter/exit path isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 058/106] KVM: TDX: vcpu_run: save/restore host state(host kernel gs) isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 059/106] KVM: TDX: restore host xsave state when exit from the guest TD isaku.yamahata
2023-02-27  8:22 ` [PATCH v12 060/106] KVM: x86: Allow to update cached values in kvm_user_return_msrs w/o wrmsr isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 061/106] KVM: TDX: restore user ret MSRs isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 062/106] [MARKER] The start of TDX KVM patch series: TD vcpu exits/interrupts/hypercalls isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 063/106] KVM: TDX: complete interrupts after tdexit isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 064/106] KVM: TDX: restore debug store when TD exit isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 065/106] KVM: TDX: handle vcpu migration over logical processor isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 066/106] KVM: x86: Add a switch_db_regs flag to handle TDX's auto-switched behavior isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 067/106] KVM: TDX: Add support for find pending IRQ in a protected local APIC isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 068/106] KVM: x86: Assume timer IRQ was injected if APIC state is proteced isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 069/106] KVM: TDX: remove use of struct vcpu_vmx from posted_interrupt.c isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 070/106] KVM: TDX: Implement interrupt injection isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 071/106] KVM: TDX: Implements vcpu request_immediate_exit isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 072/106] KVM: TDX: Implement methods to inject NMI isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 073/106] KVM: VMX: Modify NMI and INTR handlers to take intr_info as function argument isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 074/106] KVM: VMX: Move NMI/exception handler to common helper isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 075/106] KVM: x86: Split core of hypercall emulation to helper function isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 076/106] KVM: TDX: Add a place holder to handle TDX VM exit isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 077/106] KVM: TDX: Handle vmentry failure for INTEL TD guest isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 078/106] KVM: TDX: handle EXIT_REASON_OTHER_SMI isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 079/106] KVM: TDX: handle ept violation/misconfig exit isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 080/106] KVM: TDX: handle EXCEPTION_NMI and EXTERNAL_INTERRUPT isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 081/106] KVM: TDX: Add a place holder for handler of TDX hypercalls (TDG.VP.VMCALL) isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 082/106] KVM: TDX: handle KVM hypercall with TDG.VP.VMCALL isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 083/106] KVM: TDX: Add KVM Exit for TDX TDG.VP.VMCALL isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 084/106] KVM: TDX: Handle TDX PV CPUID hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 085/106] KVM: TDX: Handle TDX PV HLT hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 086/106] KVM: TDX: Handle TDX PV port io hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 087/106] KVM: TDX: Handle TDX PV MMIO hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 088/106] KVM: TDX: Implement callbacks for MSR operations for TDX isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 089/106] KVM: TDX: Handle TDX PV rdmsr/wrmsr hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 090/106] KVM: TDX: Handle TDX PV report fatal error hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 091/106] KVM: TDX: Handle TDX PV map_gpa hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 092/106] KVM: TDX: Handle TDG.VP.VMCALL<GetTdVmCallInfo> hypercall isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 093/106] KVM: TDX: Silently discard SMI request isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 094/106] KVM: TDX: Silently ignore INIT/SIPI isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 095/106] KVM: TDX: Add methods to ignore accesses to CPU state isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 096/106] KVM: TDX: Add methods to ignore guest instruction emulation isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 097/106] KVM: TDX: Add a method to ignore dirty logging isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 098/106] KVM: TDX: Add methods to ignore VMX preemption timer isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 099/106] KVM: TDX: Add methods to ignore accesses to TSC isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 100/106] KVM: TDX: Ignore setting up mce isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 101/106] KVM: TDX: Add a method to ignore for TDX to ignore hypercall patch isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 102/106] KVM: TDX: Add methods to ignore virtual apic related operation isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 103/106] Documentation/virt/kvm: Document on Trust Domain Extensions(TDX) isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 104/106] KVM: x86: design documentation on TDX support of x86 KVM TDP MMU isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 105/106] RFC: KVM: TDX: Make busy with S-EPT on entry bug isaku.yamahata
2023-02-27  8:23 ` [PATCH v12 106/106] [MARKER] the end of (the first phase of) TDX KVM patch series isaku.yamahata
2023-02-28  8:03 ` [PATCH v12 000/106] KVM TDX basic feature support Xiaoyao Li
2023-03-01  0:45   ` Isaku Yamahata
2023-03-01  1:19     ` [PATCH v12 1/6] KVM: VMX: Move out vmx_x86_ops to 'main.c' to wrap VMX and TDX isaku.yamahata
2023-03-01  1:19       ` [PATCH v12 2/6] KVM: x86/vmx: Refactor KVM VMX module init/exit functions isaku.yamahata
2023-03-01  1:19       ` [PATCH v12 3/6] KVM: TDX: Initialize the TDX module when loading the KVM intel kernel module isaku.yamahata
2023-03-01  1:19       ` [PATCH v12 4/6] KVM: TDX: Add placeholders for TDX VM/vcpu structure isaku.yamahata
2023-03-01  1:19       ` [PATCH v12 5/6] KVM: x86: Introduce vm_type to differentiate default VMs from confidential VMs isaku.yamahata
2023-04-11 10:09         ` Zhi Wang
2023-03-01  1:19       ` [PATCH v12 6/6] KVM: TDX: Make TDX VM type supported isaku.yamahata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bb83ed60289137bcc2ca72c56a88c2f935536af.1677484918.git.isaku.yamahata@intel.com \
    --to=isaku.yamahata@intel.com \
    --cc=dmatlack@google.com \
    --cc=erdemaktas@google.com \
    --cc=isaku.yamahata@gmail.com \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sagis@google.com \
    --cc=seanjc@google.com \
    --cc=zhi.wang.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).