linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <ren_guo@c-sky.com>
To: akpm@linux-foundation.org, arnd@arndb.de,
	daniel.lezcano@linaro.org, davem@davemloft.net,
	gregkh@linuxfoundation.org, hch@infradead.org,
	marc.zyngier@arm.com, mark.rutland@arm.com, peterz@infradead.org,
	robh@kernel.org, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	c-sky_gcc_upstream@c-sky.com, Guo Ren <ren_guo@c-sky.com>
Subject: [PATCH V9 21/21] csky: support dword access for get_user_size()
Date: Tue, 16 Oct 2018 13:48:19 +0800	[thread overview]
Message-ID: <4bc11ff0cff5960892a464189605f9bc808383fc.1539655732.git.ren_guo@c-sky.com> (raw)
In-Reply-To: <cover.1539655731.git.ren_guo@c-sky.com>

Support dword access for get_user_size and redesign put_user_size with
the same style of get_user_size. It's Ok to use xxx_user_asm_common for
all size of variable with ldb, ldh, ldw, ld.d

ld.d rx, (addr, 0) could "rx <= addr" "and r(x+1) <= addr+4" and this also
follow abiv2 gcc ABI for dword access.

abiv1 couldn't support __get_user_dword now.

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Cc: Arnd Bergmann <arnd@arndb.de>
---
 arch/csky/include/asm/uaccess.h | 140 ++++++++++++++++------------------------
 1 file changed, 56 insertions(+), 84 deletions(-)

diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h
index acaf0e210..80233e4 100644
--- a/arch/csky/include/asm/uaccess.h
+++ b/arch/csky/include/asm/uaccess.h
@@ -96,90 +96,32 @@ extern int __put_user_bad(void);
 	__pu_err;							\
 })
 
-#define __put_user_size(x, ptr, size, retval)		\
-do {							\
-	retval = 0;					\
-	switch (size) {                                 \
-	case 1:						\
-		__put_user_asm_b(x, ptr, retval);	\
-		break;					\
-	case 2:						\
-		__put_user_asm_h(x, ptr, retval);	\
-		break;					\
-	case 4:						\
-		__put_user_asm_w(x, ptr, retval);	\
-		break;					\
-	case 8:						\
-		__put_user_asm_64(x, ptr, retval);	\
-		break;					\
-	default:					\
-		__put_user_bad();			\
-	}	                                        \
-} while (0)
-
-/*
- * We don't tell gcc that we are accessing memory, but this is OK
- * because we do not write to any memory gcc knows about, so there
- * are no aliasing issues.
- *
- * Note that PC at a fault is the address *after* the faulting
- * instruction.
- */
-#define __put_user_asm_b(x, ptr, err)			\
-do {							\
-	int errcode;					\
-	asm volatile(					\
-	"1:     stb   %1, (%2,0)	\n"		\
-	"       br    3f		\n"		\
-	"2:     mov   %0, %3		\n"		\
-	"       br    3f		\n"		\
-	".section __ex_table, \"a\"	\n"		\
-	".align   2			\n"		\
-	".long    1b,2b			\n"		\
-	".previous			\n"		\
-	"3:				\n"		\
-	: "=r"(err), "=r"(x), "=r"(ptr), "=r"(errcode)	\
-	: "0"(err), "1"(x), "2"(ptr), "3"(-EFAULT)	\
-	: "memory");					\
-} while (0)
-
-#define __put_user_asm_h(x, ptr, err)			\
-do {							\
-	int errcode;					\
-	asm volatile(					\
-	"1:     sth   %1, (%2,0)	\n"		\
-	"       br    3f		\n"		\
-	"2:     mov   %0, %3		\n"		\
-	"       br    3f		\n"		\
-	".section __ex_table, \"a\"	\n"		\
-	".align   2			\n"		\
-	".long    1b,2b			\n"		\
-	".previous			\n"		\
-	"3:				\n"		\
-	: "=r"(err), "=r"(x), "=r"(ptr), "=r"(errcode)	\
-	: "0"(err), "1"(x), "2"(ptr), "3"(-EFAULT)	\
-	: "memory");					\
-} while (0)
-
-#define __put_user_asm_w(x, ptr, err)			\
-do {							\
-	int errcode;					\
-	asm volatile(					\
-	"1:     stw   %1, (%2,0)	\n"		\
-	"       br    3f		\n"		\
-	"2:     mov   %0, %3		\n"		\
-	"       br    3f		\n"		\
-	".section __ex_table,\"a\"	\n"		\
-	".align   2			\n"		\
-	".long    1b, 2b		\n"		\
-	".previous			\n"		\
-	"3:				\n"		\
-	: "=r"(err), "=r"(x), "=r"(ptr), "=r"(errcode)	\
-	: "0"(err), "1"(x), "2"(ptr), "3"(-EFAULT)	\
-	: "memory");					\
+#define __put_user_size(x, ptr, size, retval)			\
+do {								\
+	retval = 0;						\
+	switch (size) {						\
+	case 1:							\
+		__put_user_asm_common(x, ptr, "stb", retval);	\
+		break;						\
+	case 2:							\
+		__put_user_asm_common(x, ptr, "sth", retval);	\
+		break;						\
+	case 4:							\
+		__put_user_asm_common(x, ptr, "stw", retval);	\
+		break;						\
+	case 8:							\
+		__put_user_asm_dword(x, ptr, retval);		\
+		break;						\
+	default:						\
+		__put_user_bad();				\
+	}							\
 } while (0)
 
-#define __put_user_asm_64(x, ptr, err)				\
+#if defined(__CSKYABIV2__)
+#define __put_user_asm_dword(x, ptr, err)			\
+	__put_user_asm_common(x, ptr, "st.d", err)
+#else
+#define __put_user_asm_dword(x, ptr, err)			\
 do {								\
 	int tmp;						\
 	int errcode;						\
@@ -205,6 +147,25 @@ do {								\
 	: "0"(err), "1"(psrc), "2"(ptr), "3"(0), "4"(-EFAULT)	\
 	: "memory");						\
 } while (0)
+#endif
+
+#define __put_user_asm_common(x, ptr, ins, err)			\
+do {								\
+	int errcode;						\
+	asm volatile(						\
+	"1:   " ins "	%1, (%2,0)	\n"			\
+	"       br	3f		\n"			\
+	"2:     mov	%0, %3		\n"			\
+	"       br	3f		\n"			\
+	".section __ex_table, \"a\"	\n"			\
+	".align   2			\n"			\
+	".long    1b,2b			\n"			\
+	".previous			\n"			\
+	"3:				\n"			\
+	: "=r"(err), "=r"(x), "=r"(ptr), "=r"(errcode)		\
+	: "0"(err), "1"(x), "2"(ptr), "3"(-EFAULT)		\
+	: "memory");						\
+} while (0)
 
 #define __get_user_nocheck(x, ptr, size)			\
 ({								\
@@ -222,6 +183,7 @@ do {								\
 	__gu_err;						\
 })
 
+extern int __get_user_bad(void);
 #define __get_user_size(x, ptr, size, retval)			\
 do {								\
 	switch (size) {						\
@@ -234,12 +196,24 @@ do {								\
 	case 4:							\
 		__get_user_asm_common((x), ptr, "ldw", retval);	\
 		break;						\
+	case 8:							\
+		__get_user_asm_common((x), ptr, "ld.d", retval);\
+		break;						\
 	default:						\
 		x = 0;						\
 		(retval) = __get_user_bad();			\
 	}							\
 } while (0)
 
+#if defined(__CSKYABIV2__)
+#define __get_user_asm_dword(x, ptr, err)			\
+	__get_user_asm_common(x, ptr, "ld.d", err)
+#else
+/* fixme: abiv1 not implement get_user_dword */
+#define __get_user_asm_dword(x, ptr, err)			\
+	__get_user_bad()
+#endif
+
 #define __get_user_asm_common(x, ptr, ins, err)			\
 do {								\
 	int errcode;						\
@@ -260,8 +234,6 @@ do {								\
 	: "memory");						\
 } while (0)
 
-extern int __get_user_bad(void);
-
 #define __copy_user(to, from, n)			\
 do {							\
 	int w0, w1, w2, w3;				\
-- 
2.7.4


  parent reply	other threads:[~2018-10-16  5:48 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16  2:58 [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port Guo Ren
2018-10-16  2:58 ` [PATCH V9 01/21] csky: Build infrastructure Guo Ren
2018-10-23  0:08   ` Guo Ren
2018-10-24 22:53     ` Arnd Bergmann
2018-10-25 17:04       ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 02/21] csky: defconfig Guo Ren
2018-10-17 14:56   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 03/21] csky: Kernel booting Guo Ren
2018-10-17 14:58   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 04/21] csky: Exception handling and mm-fault Guo Ren
2018-10-17 14:59   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 05/21] csky: System Call Guo Ren
2018-10-17 15:02   ` Arnd Bergmann
2018-10-18  2:02     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 06/21] csky: Cache and TLB routines Guo Ren
2018-10-17 15:08   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 07/21] csky: MMU and page table management Guo Ren
2018-10-17 15:06   ` Arnd Bergmann
2018-10-18  2:05     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 08/21] csky: Process management and Signal Guo Ren
2018-10-17 15:11   ` Arnd Bergmann
2018-10-18  2:37     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 09/21] csky: VDSO and rt_sigreturn Guo Ren
2018-10-17 15:13   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 10/21] csky: IRQ handling Guo Ren
2018-10-17 15:14   ` Arnd Bergmann
2018-10-18  2:39     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 11/21] csky: Atomic operations Guo Ren
2018-10-17 15:17   ` Arnd Bergmann
2018-10-18  2:40     ` Guo Ren
2018-10-21 20:55   ` Peter Zijlstra
2018-10-22  1:52     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 12/21] csky: ELF and module probe Guo Ren
2018-10-17 15:18   ` Arnd Bergmann
2018-10-18  2:49     ` Guo Ren
2018-10-18  8:31       ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 13/21] csky: Library functions Guo Ren
2018-10-17 15:24   ` Arnd Bergmann
2018-10-18  3:10     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 14/21] csky: User access Guo Ren
2018-10-17 15:37   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 15/21] csky: Debug and Ptrace GDB Guo Ren
2018-10-17 15:46   ` Arnd Bergmann
2018-10-18  3:17     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 16/21] csky: SMP support Guo Ren
2018-10-17 15:47   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 17/21] csky: Misc headers Guo Ren
2018-10-17 15:49   ` Arnd Bergmann
2018-10-16  2:58 ` [PATCH V9 18/21] dt-bindings: csky CPU Bindings Guo Ren
2018-10-17 15:50   ` Arnd Bergmann
2018-10-18  3:21     ` Guo Ren
2018-10-18  3:45       ` Guo Ren
2018-10-18 14:31   ` Rob Herring
2018-10-19  2:19     ` Guo Ren
2018-10-16  2:58 ` [PATCH V9 19/21] dt-bindings: Add vendor prefix for csky Guo Ren
2018-10-16  2:58 ` [PATCH V9 20/21] MAINTAINERS: Add csky Guo Ren
2018-10-17 15:51   ` Arnd Bergmann
2018-10-16  5:48 ` Guo Ren [this message]
2018-10-17 15:44   ` [PATCH V9 21/21] csky: support dword access for get_user_size() Arnd Bergmann
2018-10-18  3:41     ` Guo Ren
2018-10-18  8:34       ` Arnd Bergmann
2018-10-18  8:57         ` Guo Ren
2018-10-24  7:17           ` Arnd Bergmann
2018-10-25 17:08             ` Guo Ren
2018-10-17 15:58 ` [PATCH V9 00/21] C-SKY(csky) Linux Kernel Port Arnd Bergmann
2018-10-18  4:10   ` Guo Ren
2018-10-18  8:36     ` Arnd Bergmann
2018-10-18  9:03       ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bc11ff0cff5960892a464189605f9bc808383fc.1539655732.git.ren_guo@c-sky.com \
    --to=ren_guo@c-sky.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=c-sky_gcc_upstream@c-sky.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH V9 21/21] csky: support dword access for get_user_size()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).