From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933807AbdKAXIt (ORCPT ); Wed, 1 Nov 2017 19:08:49 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:52239 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933464AbdKAXIr (ORCPT ); Wed, 1 Nov 2017 19:08:47 -0400 X-Google-Smtp-Source: ABhQp+SYdnX6SDYnb9mVaQrBXwROoykm8Fpeyde2t0jeQetMI5g+1CrUMpZlCvCAgzw0h+r+2/sA2A== Subject: Re: [PATCH] staging: android: ion: remove redundant variable table To: Colin King , Sumit Semwal , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171031140249.25280-1-colin.king@canonical.com> From: Laura Abbott Message-ID: <4bff9c1f-8354-9e4e-4bdd-80a90450eb7b@redhat.com> Date: Wed, 1 Nov 2017 16:08:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171031140249.25280-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2017 07:02 AM, Colin King wrote: > From: Colin Ian King > > Variable table is being set but is never read, it is therefore > redundant and can be removed. Cleans up clang warning: > > drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read > Acked-by: Laura Abbott > Signed-off-by: Colin Ian King > --- > drivers/staging/android/ion/ion.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 93e2c90fa77d..a7d9b0e98572 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, > unsigned long flags) > { > struct ion_buffer *buffer; > - struct sg_table *table; > int ret; > > buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); > @@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap, > goto err1; > } > > - table = buffer->sg_table; > buffer->dev = dev; > buffer->size = len; > >