From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBADC4320A for ; Wed, 4 Aug 2021 05:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9494460F35 for ; Wed, 4 Aug 2021 05:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235100AbhHDFDU (ORCPT ); Wed, 4 Aug 2021 01:03:20 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:12443 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbhHDFDS (ORCPT ); Wed, 4 Aug 2021 01:03:18 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Gfffm4sVzzcfZ0; Wed, 4 Aug 2021 12:59:28 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:02 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 4 Aug 2021 13:03:01 +0800 Subject: Re: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() To: Palmer Dabbelt CC: , , , Greg KH , , , , , , References: From: Kefeng Wang Message-ID: <4c0ec8b2-6b9c-d8da-dd84-29937c968636@huawei.com> Date: Wed, 4 Aug 2021 13:03:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/4 8:20, Palmer Dabbelt wrote: > On Fri, 30 Jul 2021 00:04:05 PDT (-0700), wangkefeng.wang@huawei.com > wrote: >> >> On 2021/7/30 14:49, Liang Wang wrote: >>> The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled), >>> use PFN_PHYS() in devmem_is_allowed(), or the physical address may >>> overflow and be truncated. >>> >>> This bug was initially introduced from v2.6.37, and the function was >>> moved >>> to lib when v5.10. >>> >>> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by >>> disabling access to RAM via /dev/mem") >>> Fixes: 527701eda5f1 ("lib: Add a generic version of >>> devmem_is_allowed()") >>> Cc: stable@vger.kernel.org # v2.6.37 >>> Signed-off-by: Liang Wang >> Reviewed-by: Kefeng Wang >>> --- >>> v2: update subject and changelog >>>   lib/devmem_is_allowed.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) ... > Acked-by: Palmer Dabbelt > > I only see the reply so I'm assuming this is going in through some > other tree, but LMK if you want it via the RISC-V tree as IIRC we're > using it too. Hi Palmer,  there is a v3 with changelog updated, https://lore.kernel.org/lkml/20210731025057.78825-1-wangliang101@huawei.com/ > > Thanks! > . >